search

Medium / phantomjs

NPM wrapper for installing phantomjs
Other
1.42k stars 435 forks source link

Breaking change - installation of 2.1.14 fails on FreeBSD #655

Open tsvetomir opened 7 years ago

tsvetomir commented 7 years ago

I understand that the package never supported FreeBSD due to the lack of a pre-built binary for this platform. This is discussed in #636

Consider the scenario. A project depends on the package, but only for a subset of its functionality. The functionality that depends on PhantomJS is not actually invoked on FreeBSD.

So we have:

I consider making this a "hard failure" a breaking change.

nicks commented 7 years ago

I'm open to other suggestions. I'm not sure I buy the argument that the state you were in -- where the deps weren't properly installed and random parts of the library would work or not work -- is a valid state that we should be obligated to support.

tsvetomir commented 7 years ago

My suggestion is to print out a warning that no binary was found or it is with the wrong version.

This is not to say that I don't agree with the change. But I wouldn't expect a patch version to turn a "soft" error into a "hard" error.

The package in questions is a collection of gulp tasks. Some of them are used during development, some are used during the build process.