search

Medium / phantomjs

NPM wrapper for installing phantomjs
Other
1.42k stars 436 forks source link

Force a fixed version for `request` dependency due to non-availabilit… #783

Open nick13jaremek opened 6 years ago

nick13jaremek commented 6 years ago

…y of async/await function sin NodeJS versions 6.x/7x.

request upgraded its version from 2.83.0 to 2.84.0, commiting a version change on its package.json file for the hawk NPM dependency, from 6.x to 7.x.

Such hawk dependency version refers to the sntp library, which uses async/await statements in its codebase.

Due to this dependency chain, new installs of phantomjs fail in environments that use NodeJS versions 6.x or 7.x, since these node versions do not support the async/await functions by default.

nick13jaremek commented 6 years ago

Will require version upgrade and NPM publishing of the newest version.

Wlada commented 6 years ago

Merge? Thanks