Medium / phantomjs

NPM wrapper for installing phantomjs
Other
1.42k stars 436 forks source link

Location file created with invalid path separators in Windows #820

Open blastedt opened 5 years ago

blastedt commented 5 years ago

Version: 2.1.15 Node version: 8.9.x OS: Windows 10 x64 After install, the module generates a location.js that looks like this: module.exports.location = 'C:\ui\proj\node_modules\phantomjs-bin\bin\win32\phantomjs.exe'; It should instead generate like this: module.exports.location = 'C:\\ui\\proj\\node_modules\\phantomjs-bin\\bin\\win32\\phantomjs.exe';

This causes launch to fail until you do something like this to your karma conf (pick your poison on test runners): require('phantomjs-prebuilt').path = 'C:\\ui\\proj\\node_modules\\phantomjs-bin\\bin\\win32\\phantomjs.exe'

This issue occurs kind of inconsistently across machines but I've experienced it on at least two so far.