search

Medium / phantomjs

NPM wrapper for installing phantomjs
Other
1.42k stars 436 forks source link

Mark deprecated #825

Closed wbt closed 4 years ago

wbt commented 4 years ago

Maintenance of the underlying phantomjs library was suspended last year, following an announcement the year before. Nowhere in the readme (republished on npm) is this mentioned, and the opposite impression is given by its first full sentences:

What this installer is really doing is just grabbing a particular "blessed" (by this module) version of Phantom. As new versions of Phantom are released and vetted, this module will be updated accordingly.

The PhantomJS link at the start of the readme points to that project's official website, which opens by saying:

Important: PhantomJS development is suspended until further notice (more details).

The last publish of the library, as noted on the NPM page, was 2 years ago. There are vulnerabilities in dependencies and other issues in functionality.

This package should be marked as deprecated in NPM.
Explanatory text should also be added to the readme.

Doing so will help reduce the number of projects adding this as a dependency and encourage projects already using it to shift to something more maintained, like headless Chrome.

This would take relatively little time from @Medium which is clearly still in operation, and could help reduce the flow of incoming Issues and associated attention requirements. @valueof, do you have permissions to do this?

(My ability to investigate further details is blocked by some serious issues with GitHub going on now, so I'm filing this Issue while it still seems possible to do so.)

valueof commented 4 years ago

Thanks for raising this. Let me see if I can deprecate the package.

wbt commented 4 years ago

Thanks! If possible, please also do the same with bundled-phantomjs-prebuilt and phantomjs-prebuilt2 and phantomjs-prebuilt-macbre which all point to this GitHub repo.

@juliangruber You may wish to do the same with your fork. (GitHub issues cannot be raised on forks.)

@zeevl Same with your fork!

zeevl commented 4 years ago

Done. Thanks for the poke!

valueof commented 4 years ago

I've deprecated our NPM package. Unfortunately, we don't have access to the other three packages since they are maintained by the outside developers. I've also updated the README and going to archive this repo shortly.

Again, thank you for raising this, @wbt, I really appreciate it.