search

Mee42 / cs509-project

2 stars 0 forks source link

(RFC) OrderBy and SortBy are unused enums and strings are used where the enums should be used #32

Closed Mee42 closed 7 months ago

Mee42 commented 7 months ago

The only lines where I can find references to the enums themselves is in the getFlightInfo function where we transform a string into the enum representation and then back into the string representation. I think we should try and replace all of the uses of the string representation into the enum representation

Chinh - happy to take this one, just wanted your opinion on it before I start doing refactoring of code you've been working on

ChinhDangg commented 7 months ago

You are right, since I use the string representation of the enums in the jdbc query anyway, using enums all the ways should work too. You can refactor it