Meeds-io / MIPs

The Meeds Improvement Proposal repository
0 stars 0 forks source link

Add link to text #107

Closed srenault-meeds closed 5 months ago

srenault-meeds commented 7 months ago

Rationale

Currently, when you post a message, a comment, and you want to share a link, you have no way to insert this link into a text in order to make it nicer. Example:

image

Suggestion: allow user to select a content, then add link to it so that:

Alternative: any editor provides nowadays options to add link into a content

1. Functional Requirements

Top User Stories

When writing a message (activity, comment, kudos, task comment, action) OR when writing a note, a SNV, Then I can select a text so a balloon toolbar proposes me to add a link

image

When doing so, I can insert the link

image

Once done, when clicking to it while editing, the toolbar suggests me to edit or to remove the link.

image

Precision To study: add other options in the balloon toolbar to quickly make the text bold or italic (still quicker than clicking to the editor toolbar)

Impacts

Gamification

Notifications

Analytics

Unified Search

2. Technical Requirements

Security

Generated links must be secure and don't allow XSS attacks.

Extensibility

This plugin has to be proposed as an extension but not defined by default in all RicheEditor instances.

Feature Flags

No feature flag is needed.

3. Software Architecture

Access

The CKEditor plugin Balloon Toolbar should be used. This plugin will require a customization to integrate desired buttons into it. This feature has to be part of RichEditor.vue to be able to enable it when needed in all existing rich editor instances.

srenault-meeds commented 7 months ago

To check please @margondicco

margondicco commented 7 months ago

Hello Go Fonc

srenault-meeds commented 7 months ago

Thanks. Ready for tech spec writing @boubaker

boubaker commented 7 months ago

Thanks. Ready for tech spec writing @boubaker

ok, thanks.

boubaker commented 7 months ago

Ready for spec Review by DAO Members (eXo : @rdenarie )

rdenarie commented 7 months ago

ok for me go tech

boubaker commented 5 months ago

Ready for Review with ACCs Up & Running.

rdenarie commented 5 months ago

Hello @SaraBoutej Can you link PRs in this MIPs ? You can use the right column :

Image

Or add a comment listing PRs.

It make it easier to be sure that all PRs are validated.

I just validate 2 prs (social and commons), but I'm not sure it is the only 2 ones

boubaker commented 5 months ago

@SaraBoutej Can you link PRs in this MIPs ?

Done, boths PRs seems reviewed. Thanks.