Meeds-io / MIPs

The Meeds Improvement Proposal repository
0 stars 0 forks source link

Oganizational Chart #112

Closed Julien-Dubois-eXo closed 1 month ago

Julien-Dubois-eXo commented 5 months ago

Rationale

Many organizations ask to be able to have an organization diagram in the platform. In order to implement the relation between user we should be able to identified the manager of the users.

1. Functional Requirements

Top User Stories

Field manager

Profile
Administration

image

Image

Organization chart

Image

Image

Image

Expand view

Image

Image

Image

Image

Image

Image

2. Technical Requirements

Expected Volume & Performance

N/A

Security

This feature will use existing security mechanisms

Extensibility

No extensibility requirements

Configurability

Configurations will be added for :

Upgradability

Requirements related to existing features

Feature Flags

No feature flag will be added, unless the org chat feature is not needed on Meeds side should we disable by default the Org chart for Meeds ?

Other Non Functional Requirements

Make sure that the new developments respect the accessibility requirements

Impacts

Documentation Training

Software Architecture

Security

Access

Rest API design

Portlet Vue & Vuetify

Services & processing

Data and persistence

No new data model to add

Migration strategy

Annexes

Reasoning that explain the technical choices Impacts References

Julien-Dubois-eXo commented 5 months ago

@ahamdi @rdenarie can you complete the technical part please?

Julien-Dubois-eXo commented 5 months ago

@srenault-meeds could you check the functional part please?

srenault-meeds commented 5 months ago

Hello, what is the rationale please? I mean, which problem are you trying to solve? Thanks

Julien-Dubois-eXo commented 5 months ago

Edited

srenault-meeds commented 5 months ago

Thanks. It looks like this MIP is highly related to an organizational chart which Meeds doesn't provide. If such feature is planned to be worked, then I suggest to work this manager field in the same MIP as it is related. Thanks

rdenarie commented 5 months ago

The only subject of this MIP is to allow to have a field with a type "user" in the profile, in addition of the type text. This is a prerequisite to organizational chart feature, which will not be in meeds, and not in a MIP.

The "user" type is in Meeds code, so this MIP. The org chart will use this new type, and will not be in Meeds code.

If you prefer, we can make a simple issue to add the new type

srenault-meeds commented 5 months ago

I didn't know that this chart won't be in Meeds. let's discuss about it ;-)

rdenarie commented 5 months ago

It was my understanding. Perhaps wrong. cc @margondicco

Julien-Dubois-eXo commented 5 months ago

@srenault-meeds the manager field will start soon. Probably the beginning of next week. Could you check the functional part please?

@margondicco For the export do you have an idea of what information (especially the relation between people) you want? I have difficulty seeing how to organize it in a CSV. @srenault-meeds your opinion would be valuable too.

The technical part of the manager field will be provided in the day coming.

plamarque commented 5 months ago

Renamed this MIP to something simpler. The manager field being just a requirement for the org chart

ahamdi commented 4 months ago

@boubaker @rdenarie Ready for tech review

rdenarie commented 4 months ago

We wait go fonc before requesting the go tech

 @Julien-Dubois-eXo and @srenault-meeds can you synchronize to give the go func ?

Thanks

Julien-Dubois-eXo commented 4 months ago

@srenault-meeds I have added some mock-ups for:

  1. adding a manager in the contact information drawer manually
  2. Organizational chart based on what we have discussed last time

Could you check to give go func for the end of this week? We will start at the beginning of next the manager.

boubaker commented 4 months ago

@boubaker @rdenarie Ready for tech review

Yes. Thanks for the technical details. Let's wait for the Go func first to ensure that the functional requirement doesn't change (thus the technical requirements doesn't change neither) and then I 'll take care of it.

Julien-Dubois-eXo commented 4 months ago

@srenault-meeds I have added the design for the organizational chart setting drawer.

srenault-meeds commented 4 months ago

Hello,

Feedbacks:

if the field is inactive could we still provide value thanks to CSV or AS/LDAP for it? QUID about the organizational chart?

Question in a MIP. Did you get your answers? Are there still questions?

Mail: to send a mail with the default mailing software of the device

What is this?

chip to indicate the number of N-1 user linked to this users - no action on this chip

Tooltip?

if possible a PDF with all the text that can be search in the PDF if not possible an image of the current view

Still an ongoing ideation? Can you please confirm the expected outcome?

Mockup Still items to review IMO to make it unique and not a copy from Office. Let's discuss about it

Julien-Dubois-eXo commented 4 months ago

if the field is inactive could we still provide value thanks to CSV or AS/LDAP for it? QUID about the organizational chart? I had one but was not convinced by it. I'm interested in your point of view.

Mail: to send a mail with the default mailing software of the device It's a feature asked by @margondicco. It opens the mail software of the device with the user email address.

chip to indicate the number of N-1 user linked to this users - no action on this chip Yes why not. I just want to say there is no action on click. I have not think about the tooltip yet. I will do it during the US redaction.

if possible a PDF with all the text that can be search in the PDF if not possible an image of the current view It's more depending on the technical feasibility. The ideal expected outcome is the PDF. @ahamdi is currently checking that point.

No problem discussing the mock-ups there are some points I have difficulty to do it with Miro.

srenault-meeds commented 4 months ago

Mail: to send a mail with the default mailing software of the device It's a feature asked by @margondicco. It opens the mail software of the device with the user email address.

Is that really mandatory? Indeed, we might have cases where we have hide emails. Example: Builders -> Email are hidden Option suggested: If you really want to display the email in the card, then use the option to list other items in the card (instead of the city, the department, etc.)

srenault-meeds commented 4 months ago

Excepted this point, GO Func for me. Tell me if objection regarding email

margondicco commented 4 months ago

No objection with your proposal @srenault-meeds . Indeed some of our client don't want email.

Julien-Dubois-eXo commented 4 months ago

@srenault-meeds I have changed the designed of the organisational chart settings based on your proposition. @margondicco FYI

srenault-meeds commented 4 months ago

Go Func

boubaker commented 4 months ago

Go tech

Julien-Dubois-eXo commented 1 month ago

@srenault-meeds ready to be tested on MIPs-acceptance.

ahamdi commented 1 month ago

PR to merge proposed

srenault-meeds commented 1 month ago

Hello

LGTM except one thing. Why am I authorized to update the setting of a chart even when not an admin?

image
ahamdi commented 1 month ago

Hello

LGTM except one thing. Why am I authorized to update the setting of a chart even when not an admin? image

@srenault-meeds I agree the configuration button should not be visible for normal users. we will fix it asap cc @Julien-Dubois-eXo

srenault-meeds commented 1 month ago

Hi @ahamdi @margondicco

We discussed about a flag for meeds package to not display the org. chart to users as it is not relevant. Can you please provide us the property to change so I can test it out?

Thanks.

cc @plamarque

srenault-meeds commented 1 month ago

As discussed with @margondicco, the organizational chart access will be hidden from the time the manager field is not enabled from profile administration

srenault-meeds commented 1 month ago

Hello @Julien-Dubois-eXo @rdenarie it seems this is still pending. We (meedslab) suggest to push it to develop. And we hope that you will be able to hide the org chart if needed, but afterwards

cc @margondicco

ahamdi commented 1 month ago

Hello @Julien-Dubois-eXo @rdenarie it seems this is still pending. We (meedslab) suggest to push it to develop. And we hope that you will be able to hide the org chart if needed, but afterwards

cc @margondicco

Hi @srenault-meeds , everything is OK from our side, I updated the feature/mips and the pull requests for develop. many feedback were already fixed and integrated in the merge PR including the hiding of the My Team and Organizationalchart pages when manager field is disabled But I had some DB issues with acceptance server that I want to investigate and understand its causes. It should be ok for tomorrow, I will ping you once it is done

srenault-meeds commented 1 month ago

Ok tell me once available to test it out

srenault-meeds commented 1 month ago

Hello, Ok for me. The organizational chart is hidden once the Profile Field "Manager" is hidden

FYI, we still have this feedback ;-) No blocker of course! So, let's merge it to develop if ok technically speaking (PR incl.)

Why am I authorized to update the setting of a chart even when not an admin?

cc @Julien-Dubois-eXo @margondicco @ahamdi @rdenarie @boubaker

boubaker commented 1 month ago

Hello, Ok for me. The organizational chart is hidden once the Profile Field "Manager" is hidden

FYI, we still have this feedback ;-) No blocker of course! So, let's merge it to develop if ok technically speaking (PR incl.)

Why am I authorized to update the setting of a chart even when not an admin?

cc @Julien-Dubois-eXo @margondicco @ahamdi @rdenarie @boubaker

cool :+1: No objection for me