search

Meeds-io / MIPs

The Meeds Improvement Proposal repository
0 stars 0 forks source link

Bottom Bar in Left menu #117

Closed srenault-meeds closed 5 months ago

srenault-meeds commented 5 months ago

Rationale

Now that the administration site is by default something we can access from the topbar, it would be interesting to review the access to the settings and to the logout.

Indeed, it is not a major access as any other pages (spaces, my craft, contribute, etc.) and it would be more interesting to list these options at the bottom of the left menu. That way, only pages the user access the most are listed in first place.

1. Functional Requirements

Top User Stories

Given I access the left menu Then at the bottom, I can see three informations:

  1. Meeds (or anything else depending the package*)
  2. User Settings icon to access the user settings
  3. Logout icon to log out from the platform

Given I have a small device OR/AND I have lots of spaces listed Then the bottom of the menu is sticked so I can see these options AND I can scroll down when needed

Given I click to "Meeds" Then I am sent to a link that we can configure. For meeds for example, it can be the product updates blog

image

Given I want to check the version Then I can do it using rest services as currently

*Label and link need to be extensible so we can update it depending on the package used

Impacts

Gamification

NA

Notifications

NA

Analytics

Access to meeds version link

Unified Search

2. Technical Requirements

Extensibility

The Package Link displayed in bottom left of the menu should be extensible so that it can be set by package.

Existing Features

[!NOTE] No change on current behavior of features, this is just a UI change

Feature Flags

[!NOTE] No feature flag is needed

3. Software Architecture

Access

Two properties should be available in frontend to be able to display information:

Both variables should be used to display the Product Label.

srenault-meeds commented 5 months ago

@margondicco to check :)

margondicco commented 5 months ago

Hello

good idea

my feedback

Version label : i suggest "powered by Meeds (or eXo) x.y.z" button disconnect : add a rule : if there is an authentification SAML, the button disconnect is hidden

Thank you

rdenarie commented 5 months ago

Hello : NOGO for displaying the platform version : it reveal sensible platform informations. Only administrators have access to that on endpoint /platform/rest/info

srenault-meeds commented 5 months ago

Ok I have reviewed the description and the design accordingly.

Plus, I have added something regarding the display of the version:

Given I want to check the version Then I can do it using the current rule BUT this can be hidden thanks to a feature flag in case it is needed

Ok for you @rdenarie @margondicco ?

rdenarie commented 5 months ago

Then I can do it using the current rule

You mean via the rest service, as administrator ?

If you mean that, no need of feature flag. Keep the version for admin as currently is ok

If "current rule" mean something else, please explain

srenault-meeds commented 5 months ago

Yes I meant the current rest service. Updated

srenault-meeds commented 5 months ago

@margondicco I have updated the description considering different feedbacks. FYI, no "powered by..." AND regarding SAML, it is another concern we need to address sometime.

margondicco commented 5 months ago

Go fonc

srenault-meeds commented 5 months ago

Thanks. Ready for tech spec @boubaker

boubaker commented 5 months ago

Ready for Tech Review by DAO Members ( eXo : @rdenarie )

rdenarie commented 5 months ago

Go tech

boubaker commented 5 months ago

Ready for Review by DAO Members ( eXo : @margondicco @rdenarie )

ACCs Up and Running (https://mips-ft.meeds.io)

In order to change this, you may need to adopt changes in your distribution files, like made for meeds:

https://github.com/Meeds-io/meeds/pull/1580/files#diff-4a7581bde069bf35bf92f159bdc5f507aff0ce6d1ce7bc15ecfc68b8afef8edcR18-R19

plamarque commented 5 months ago

Updated title to something simpler

rdenarie commented 5 months ago

Feature ok for me. One small feedback related to accessibility on settings and logout button.

Ok to merge after fixing it

srenault-meeds commented 5 months ago

One small feedback related to accessibility on settings and logout button.

How can we help you please?

rdenarie commented 5 months ago

I comment the PR and require for a modification before merge. This one : https://github.com/Meeds-io/social/pull/3437

You just need to add the aria-label for both button

rdenarie commented 5 months ago

My last comment is resolved. You can proceed to merge

boubaker commented 5 months ago

My last comment is resolved. You can proceed to merge

ok, thanks can you review the PR again, it's blocked in fact: image

rdenarie commented 5 months ago

Done