Pending Status

[srenault-meeds]

Rationale

More you have contributors, more you need to organize the contribution review. Currently, any action submitted is considered accepted. The problem is that:

• some contribution need to be reviewed and it is difficult to know which one has been reviewed by other reviewer, etc.
• meanwhile, points are considered earned for users
• and after some time, the review can be done and thus, points are removed. Result: contributors can get confused and reviewer get tired of checking all contributions.

In addition to this, we have observed that some contributions captured automatically need to be checked afterwards. Indeed, for example, a user can add a twitter account with no follower and he can Like, RT a tweet. Result: this twitter account has no follower so it is inefficient for our community

1. Functional Requirements

Top User Stories

Regarding account connection: When someone connects his account, then the action for connecting this account is pending by default AND any related action to this account connection can be manually added as locked until this action app connection is accepted rejecting the achievement doesn't disconnect the account

Regarding automatic actions No change, any contribution is by default accepted If needed, the acceptation can be changed to rejected or to pending no notification flow identified for this case

Regarding manual actions Any manual action is, by design, pending The owner when creating the action cannot change this parameter for now

Review of contributions

• Board is reviewed:
  1. to display all status
  2. to display an extract of the contribution
  3. to remove type

• Board can be filtered to status (one choice)

  

• When the user submit his contribution (manual or connection to an account), then current notification for "Contribution submitted" remain enabled. It is still possible to disable it if needed. A work will be done later to improve targeting of notifications

• For each contribution, it is possible to:

  1. Access the detail by clicking to detail and it opens a new tab. No drawer for it for now. We will study the fact to open the comment drawer for now
  2. Update the status from the board (no more three dots)
  3. Update the status of the contribution from the contributions comment in the stream

4. Adding a comment will be done directly from the stream

• When the contribution is pending

  1. Then the comment is visible to anyone with a mention "Pending" (instead of the current "Done!")
  2. The contributor can still edit its contribution during the time it is on pending status

• When the contribution is accepted,

  1. Then the comment is visible to anyone with a mention "Approved" (instead of the current "Done!")
  2. A notification is sent to the user so he knows the contribution is accepted
  3. The contributor cannot edit its contribution once it is accepted

• When the contribution is rejected,

  1. Then the comment is made visible to anyone with a mention "Rejected" (instead of the current "Done!")
  2. A notification is sent to the user so he knows the contribution is rejected
  3. The contributor cannot edit its contribution. If needed to submit it again, then a new contribution can be submitted

Regarding rewards computing

• Pending contribution is not considered in the computing, neither in the total of points of the contributor (leaderboard)
• Contribution is considered in the computing once accepted. So, at the time, the reward is computed, we collect all contributions submitted during the period AND accepted
• Those which are still pending while submitted during the last period are eligible for next period

To study

• Ability to clone an action to start creating a new one so it is more easy and quicker to add recurrent actions (twitter, linkedin, etc.)
• Ability to use an action from another program than the current one as a condition to complete the action

Impacts

Gamification

Connectors and profile list Contributions board to review Contributions are added once accepted

Notifications

Add a notification type for contribution status: to provide a way to inform when accepted/rejected

Analytics

Unified Search

2. Technical Requirements

Expected Volume & Performance

Security

NA

Extensibility

Add new types of activity actions to update the status of the contribution from the stream.

Configurability

NA

Upgradability

NA

Existing Features

The existing achievements Board has to be improved.

Feature Flags

No feature flag is needed.

Property Name	Default Value	Target Audience	Functional Behaviour

4. Software Architecture

Security

NA

Services & processing

The default PENDING value of automatic realization status will be known from the trigger config (default false). For a manual rule, always true.

A new notification type is to be added GamificationActionVerifiedNotification.

Update the earned points account based on the pending status.

Data and persistence

We will have to add in Database Table GAMIFICATION_ACTIONS_HISTORY a new field REWARDED of type BOOLEAN to hold the realization rewarding status(default FALSE).

Migration strategy

no need for migrating old realization.

[srenault-meeds]

To check please @margondicco @plamarque

[plamarque]

How about the CANCELLED and DELETED statuses ?

[srenault-meeds]

Currently it is considered as "rejected" or it is empty. To avoid too much actions, I suggest to consider it as "rejected" with no ability to accept it, nor review it. WDYT?

[plamarque]

I suggest to consider it as "rejected" with no ability to accept it, nor review it.

OK, these states are final anyway. And anything particular to consider for notifications when reaching these statuses?

[srenault-meeds]

Good question. If we notify program owners when a contribution is submitted, then why not notifying them when the contribution is cancelled/rejected?

We have two options:

1. Notification -> Too much noise for nothing
2. No notification but a page with a placeholder -> Less noise

WDYT?

[srenault-meeds]

FYI, we have reviewed the part regarding the notification when a contribution is submitted:

New requirement

• When the user submit its contribution (manual or connection to an account), then current notification remain enabled. It is still possible to disable it if needed. A work will be done later to improve reach of notifications

The following will be worked later

• When the user submit its contribution (manual or connection to an account)
  1. Then a notification to let the owner know a new contribution has been done is sent.
  2. The comment is hidden for any other user. Only program owner and contributor can see it
• If needed, he can unwatch this activity and then he will no more receive any notification for this action

[srenault-meeds]

Added screenshots and reviewed the notification part. Ready for go-fonc check @margondicco

[margondicco]

Go Fonc

[AzmiTouil]

Ready for tech review by DAO Members (eXo: @rdenarie )

[rdenarie]

Go tech

[AzmiTouil]

MIP ready for review by the DAO members (cc @rdenarie ). Acc up & running.

[rdenarie]

Ok for me on technical side

[margondicco]

ok for me on functional side

[boubaker]

Merged to develop