Meeds-io / MIPs

The Meeds Improvement Proposal repository
0 stars 0 forks source link

Multingual in note app #70

Closed margondicco closed 11 months ago

margondicco commented 1 year ago

Rationale

Within an international context, we might need to propose translation for the same note without being able to duplicate all the knowledge base.

We should be able to propose one knowledge base with different translation according to the user language settings.

1. Functional Requirements

1.1 Translation in Note Editor

P1 - Translation option:

Image

Image

Image

Image

1.2 Translation in Note viewer

P1 - Translation options:

Image

Image

Image

Image

1.3 History version

One history version by language:

2. Technical Requirements

Expected Volume & Performance

Security

No changes that can impact app security

Extensibility

Nothing to expect

Configurability

Nothing to expect

Upgradability

No migration expected

Existing Features

Feature Flags

| Property Name | Default Value | Target Audience | Functional Behaviour | No feature flag

3. Impacts

Documentation

Notes documentation to be updated

4. Software Architecture

Security

Access

Services & processing

Data and persistence

So content is stored in the note (WIKI_PAGE), version (WIKI_PAGE_VERSION), and in draft (WIKI_DRAFT_PAGES),

To be able to allow multi langs we will need to change the model:

New data model: new

RDBMS:

Migration strategy

No migration needed

Julien-Dubois-eXo commented 1 year ago

@srenault-meeds functional requirement ready for review, please. cc @margondicco

Julien-Dubois-eXo commented 1 year ago

update the following elements:

Julien-Dubois-eXo commented 1 year ago

Update with print to PDF behavior when a translation is displayed

srenault-meeds commented 1 year ago

Hello,

Questions:

  1. Original version language:

    "When opening the editor, the original version is displayed. The original version is not corresponding to a language."

  1. display when tablet

    "Just to remind, no editor below 770px"

You tell this but in the same type I see a mockup below this information with an editor while using 770px. Does that mean you aim to enable the edition when using tablet width? If so, ok with this, but needs to review the UI to display the editor then (other MIP)

rdenarie commented 1 year ago

@boubaker Can you make a tech review on this MIPs (for GoTech)

srenault-meeds commented 1 year ago

Hello, can we please clarify the following?

P2 - Automatic translation - Not sure you it's present on Meeds.

Not on Meeds, so to remove from there

P2 or P3

Can you please clarify the scope detailed in the MIP? Only P1

Autotranslation mention in the MIP

Do we agree autotranslation here is proposed among user language preference?

Feature flags

Only during dev?

@Julien-Dubois-eXo @margondicco

Julien-Dubois-eXo commented 1 year ago

I remove the automatic translation part as it's not present in Meeds.

Yes, the feature flag will be present only during the dev, we remove it at the end of the iteration.

On the MIP there are 3 scopes: P1, P2 and P3. P2 and P3 will probably not be done in view of the progression done so far.

boubaker commented 1 year ago

Yes, the feature flag will be present only during the dev, we remove it at the end of the iteration.

ok, can you please delete the flags as it's not in the expected outcome that will be added in the final result. Thanks.

Julien-Dubois-eXo commented 1 year ago

Done

boubaker commented 1 year ago

Tech review done.

plamarque commented 1 year ago

ETA begin of october

mkrout commented 11 months ago

@boubaker @rdenarie merge pr for review: https://github.com/Meeds-io/notes/pull/873 les devs sont deployé sur les acceptances MIPS

boubaker commented 11 months ago

@boubaker @rdenarie merge pr for review: Meeds-io/notes#873 les devs sont deployé sur les acceptances MIPS

PR approved. Have a nice weekend :+1:

srenault-meeds commented 11 months ago

Hello,

No blocker for this one

I have observed a regression in SNV when having multilingual option. The title is mandatory and we cannot add any translation FYI.

image

So either we decide to not enable it for SNV at all, either we need to adjust it if really needed. To study then