Meeds-io / MIPs

The Meeds Improvement Proposal repository
0 stars 0 forks source link

feat: Display rule for a standalone site and an aggregated site (switch) #85

Closed margondicco closed 11 months ago

margondicco commented 1 year ago

Rationale

Capabilities to define a site as standalone OR aggregated in the meta site.

1. Functional Requirements

2. Software Architecture

Access

margondicco commented 1 year ago

@azayati to be completed

margondicco commented 1 year ago

@srenault-meeds

srenault-meeds commented 1 year ago

Sorry if I don't understand it well

Can you clarify this for me please?

Currently, all the spaces are binded with the option "Dynamic layout". The rule for this option must be changed to apply this one : when i go to a space, the portal layout must be the portal layout of the meta site.

srenault-meeds commented 1 year ago

Ok as discussed with Morgan. Go func

azayati commented 1 year ago

@margondicco @srenault-meeds

For a standalone site, the site isn't displayed in the left navigation and the topbar of the shared layout isn't displayed. The elements of the portal layout are displayed.

Here I say that not only the topbar of the shared layout which will not be displayed, but all the shared layout means the topbar and the left navigation, no ?

azayati commented 11 months ago

@boubaker Ready for review

boubaker commented 11 months ago

@boubaker Ready for review

Thanks, ok for me, Go Tech added.

azayati commented 11 months ago

PR https://github.com/Meeds-io/gatein-portal/pull/712 ready for review @boubaker

boubaker commented 11 months ago

PR Meeds-io/gatein-portal#712 ready for review @boubaker

PR approved.

srenault-meeds commented 11 months ago

Hello, I have some feedbacks regarding UI/UX. How can we proceed, please?

azayati commented 11 months ago

Hello, I have some feedbacks regarding UI/UX. How can we proceed, please?

@srenault-meeds This is a technical MIP, for which MIP you have the UI/UX feedbacks ?

srenault-meeds commented 11 months ago

Hello, I have some feedbacks regarding UI/UX. How can we proceed, please?

@srenault-meeds This is a technical MIP, for which MIP you have the UI/UX feedbacks ?

Not only technical from what I see in the MIP description. I have some concerns regarding this for example:

image