Meeds-io / MIPs

The Meeds Improvement Proposal repository
0 stars 0 forks source link

feat: Images portlet #89

Closed margondicco closed 1 year ago

margondicco commented 1 year ago

Rationale

The Images portlet must be moved to be used by Meeds.

1. Functional Requirements

Important information : these requirements could be completed and not deleted.

Who can change the image (same rules as the news list portlet) : 

2. Technical Requirements

Expected Volume & Performance

Security

Extensibility

Configurability

Upgradability

Existing Features

Feature Flags

Property Name Default Value Target Audience Functional Behaviour

Other Non Functional Requirements

3. Impacts

Documentation

Training

4. Software Architecture

Security

Access

Services & processing

ImageRest service will be added with the method:

Data and persistence

Clustering

Multitenancy

Integrations

Migration strategy

5. Annexes

margondicco commented 1 year ago

@azayati to be completed

azayati commented 1 year ago

@margondicco Tech part completed, Go fonct needed @srenault-meeds @boubaker Go tech needed cc @rdenarie

srenault-meeds commented 1 year ago

Go fonc

margondicco commented 1 year ago

Hello i don't know why but this information was deleted

It's an important requirement for Meeds

New requirement : an administrator must be able to modify the image when the portlet is available on a page of a site or space.

cc @azayati @srenault-meeds

srenault-meeds commented 1 year ago

Ok for me. One question: in a space, is the manager able to edit it? I guess yes but only to check.

azayati commented 1 year ago

Ok for me. One question: in a space, is the manager able to edit it? I guess yes but only to check.

@srenault-meeds currently for a space context, only the space publisher can edit it. In a non space context only the publisher of /platform/web-contributors can edit it.

azayati commented 1 year ago

New requirement : an administrator must be able to modify the image when the portlet is available on a page of a site or space.

should it be managers of /platform/administrators or even members ?

margondicco commented 1 year ago

probably *:/platform/administrators

boubaker commented 1 year ago

probably *:/platform/administrators

IMO, this should be dependent from Page Edit permissions.

azayati commented 1 year ago

@boubaker Ready for review cc @rdenarie

srenault-meeds commented 1 year ago

Need to review the functional requirements together

and @azayati it seems that technical spec is missing. It might be relevant to review it once we discuss the functional scope

azayati commented 1 year ago

@azayati it seems that technical spec is missing

@srenault-meeds I have added the technical spec in Existing Features part, since it will be globally just a transfer of code base from layout-management to social.

boubaker commented 1 year ago

Existing Features part

Existing in Meeds ?

azayati commented 1 year ago

Existing Features part

Existing in Meeds ?

existing in eXo I mean, I have moved it in to "Other Non Functional Requirements" part

rdenarie commented 1 year ago

@azayati Even if the code exists in eXo, we need to explain how the feature works, functionnaly and technically, so that it could be reviewed before merging in meeds.

We need a technical spec here.

srenault-meeds commented 1 year ago

Functionally speaking, here is the summary after discussing it with Morgan:

Is that it @margondicco?

azayati commented 1 year ago

@boubaker Ready for review

boubaker commented 1 year ago

@boubaker Ready for review

May be get a go func (fix the functional scope) on it first before reviewing the technical spec

boubaker commented 1 year ago

The Images portlet must be moved to be used by Meeds.

Does the image permissions (access & edit) follow the page access permissions ? This is very important IMO. Else, any user can access any image banner even if he's not member of a space + this will limit the users that will be able to edit the image settings. @srenault-meeds WDYT ?

margondicco commented 1 year ago

Functional requirement added.

srenault-meeds commented 1 year ago

As discussed during product committee, this MIP needs to be reviewed a little. So back to open and labels removed

srenault-meeds commented 1 year ago

Replaced by #98