Meeds-io / MIPs

The Meeds Improvement Proposal repository
0 stars 0 forks source link

Twitter Connector #94

Closed srenault-meeds closed 12 months ago

srenault-meeds commented 1 year ago

Rationale

As we aim to provide gamification connectors, we need to add new connectors to the current one (meeds, github). Twitter connector seems to be the most relevant at the time so organizations can boost their project / employee advocacy -->

1. Functional Requirements

Top User Stories

As an admin, I can access the twitter connector from the page:

image

Then I have the list of events proposed for Twitter gamification connector:

to study

image

To enable this connector, I would need to do as for any other connector (i.e GitHub):

image

Impacts

NA

Gamification

New connector

Notifications

NA

Analytics

Usage of connector:

Monitoring

Unified Search

NA

2. Technical Requirements

Expected Volume & Performance

Terminology

Security

Extensibility

Configurability

Upgradability

NA

Existing Features

NA

Feature Flags

No feature flag is needed.

4. Software Architecture

Security

REST endpoints

A rest endpoint to add for the management of the watched account by the rewarding admin

Access

All administration UIs have to be made extensible (injected using extensionRegistry) so that it prepares integration with future connectors.

Services & processing

Data and persistence

srenault-meeds commented 1 year ago

To review please @margondicco

margondicco commented 1 year ago

ok RAS Go fonc

srenault-meeds commented 1 year ago

Thanks. Ready for tech spec @AzmiTouil @boubaker

boubaker commented 1 year ago

@AzmiTouil can you please add the Tec Spec for this connector. Thanks in advance for your help

AzmiTouil commented 1 year ago

Ready for tech review by DAO Members (eXo: @rdenarie)

rdenarie commented 1 year ago

When requesting an external service, we used to log a specific message format : example :

remote_service=serviceName operation=operationName parameters="..." status=ok duration_ms=3556

This is for a successful action, and we have other message for failed request. Can you add a requirement about these logs ?

They are very usefull for diagnostic purpose and can be managed by monitoring if needed.

For the rest I'm ok.

boubaker commented 1 year ago

remote_service=serviceName operation=operationName parameters="..." status=ok duration_ms=3556

We don't use this anymore in fact (deprecated strategy for statistics collections). We rely in fact on analytics for such data collection.

rdenarie commented 1 year ago

In fact, it is not for collecting data about the Twitter API call, but the target is to have logs in case of problem.

For example : The twitter api answer Error 500 for some reason. The UI Will only say that it is not working. Having this type of logs allows to make a quicker diagnotic of the problem as the error reason is loggued.

I'm not sure the analytics API is design for this type of requirement.

The requirement I wish to add is : Allow to see quickly that the external API have a problem, and why

boubaker commented 1 year ago

In fact, the functional administrator should have such information and knows about the API rate usage. so I would say that this is a typical usage of analytics and let the logging used for trace the exception if the platform has a bug. Like in Alchemy, you have the list of API calls with the error + response code + duration, which is designed in Analytics as builtin attributes. We used to have such traces before to collect data and display it using Grafana for ITOP, but now that we are making SaaS offers, a functional administator should have all tools to make the diagnosis himself without implying to have access to a support/ITOP guy who will tell him what's happening.

rdenarie commented 1 year ago

I'm ok if such information are collected with analytics like you explain. Could it be added in technical spec ?

boubaker commented 1 year ago

Could it be added in technical spec ?

In fact, it should be a functional requirements, we have a dedicated section for it. @srenault-meeds WDYT ?

srenault-meeds commented 1 year ago

Ok added accordingly.

boubaker commented 1 year ago

@rdenarie ok for you ?

rdenarie commented 1 year ago

ok, go tech

AzmiTouil commented 12 months ago

Ready for review by DAO Members (eXo: @rdenarie ) https://mips-ft.meeds.io/portal/meeds/

rdenarie commented 12 months ago

All PR validated

AzmiTouil commented 12 months ago

All PR validated

Thanks, all PRs merged.