feat: Customize the display of space nodes icons

[margondicco]

Rationale

Currently the icons of space nodes are hardcoded. Here we want to be able to change these icons and customize them by space.

1. Functional Requirements

• Default icons (fontawesome) are defined for each node of a space
• I can change the icon
• After the change, the bottom bar (mobile version) displays the new icons
• After the change, the level 2 of the left navigation displays the new icons

Default icons

• stream : fontawesome : stream
• note : fontawesome : clipboard
• tasks :fontawesome : task
• settings : fontawesome : cog
• members : fontawesome : users
• wallet : fontawesome : wallet
• (document) : fontawesome : folder-open
• (agenda) : fontawesome : calendar-alt

2. Technical Requirements

Configurability

• We should set the icon attribute for "SpaceApplication" fields of SpaceTemplate object params configured with SpaceTemplateConfigPlugin.
• This will allow to set this icon to the created space node corresponding to the configured space template application.
• This configuration should be done in:
  • "social": For "stream", "settings" and "members" nodes.
  • "meeds": For "SpaceWallet" node.
  • "meeds": For "stream", "members", "tasks", "notes" and "settings" nodes.
  • "notes": For "notes" node.
  • "tasks": For "tasks" node.
  • wallet: For "SpaceWallet" node, the configuration of "community" space template should be added
• This modification will has an effect only for newly created spaces with configured space template.

Upgradability

• We need to implement an upgrade plugin into social upgrade modules order to set existing space navigation nodes icons based on the related page application name.

3. Software Architecture

Access

• GUI
  • We should update SpacePanelHamburgerNavigationItem.vue in order to get the space navigation node icon directly instead of hardcoding it
  • We should update SpaceMenuItem.vue in order to get the space navigation node icon directly instead of hardcoding it
• API
  • We should update getSpaceNavigations method called from the space rest API getSpaceNavigations endpoint in order to no more hardcode computing the navigation node icons, the exact stored navigation node icons should be retrieved.

[margondicco]

@azayati : to be completed

[margondicco]

@srenault-meeds

[srenault-meeds]

Ok for me. If you need an icon for wallet, please use the following instead : money-bill-alt

[margondicco]

money-bill-alt

are you sure ?

[srenault-meeds]

Well this is what we have set for rewards and we talked about it with Benjamin but ok, let's stick with the current icon then And we will update this if needed afterwards

[azayati]

@margondicco I suggest to change the title of the MIP feat: Customize space nodes icons since the storage of the space nodes icons is already in the PORTAL_NAVIGATION_NODES as any other non space node. We need just to display each space node icon in the needed location instead of the hardcoded one.

Another question, should we change also the icons of the applications under space settings:

[srenault-meeds]

Another question, should we change also the icons of the applications under space settings:

Indeed, it has to be done as well (already the case for meeds apps FYI)

[margondicco]

Good catch @azayati yes we also change the icons of the applications. i'm note sure it's already done for meeds in terms of storage

[azayati]

@boubaker ready for tech review

We need to implement an upgrade plugin in order to set existing space navigation nodes icons based on the related page application name.

I have just a doubt about how doing this point for meeds since it not have the data-upgrade addon, should this be done manually ? cc @margondicco @srenault-meeds @rdenarie

[boubaker]

ok for me, please delete empty sections to make this easily readable. (same for all MIPs, we intend to delete empty sections in fact)

[azayati]

ok for me, please delete empty sections to make this easily readable. (same for all MIPs, we intend to delete empty sections in fact)

done, even for other MIPs, thanks

[margondicco]

@boubaker ready for tech review

We need to implement an upgrade plugin in order to set existing space navigation nodes icons based on the related page application name.

I have just a doubt about how doing this point for meeds since it not have the data-upgrade addon, should this be done manually ? cc @margondicco @srenault-meeds @rdenarie

Hello After our discussion I confirm the need for a upgrade plugin for Meeds. To manage the different historical situations , we'll need to look at the portlet on the different space page (and not the uri) to apply the right icons

[azayati]

PR ready for review & Mips ACC updated:

• https://github.com/Meeds-io/social/pull/3150
• https://github.com/Meeds-io/notes/pull/833
• https://github.com/Meeds-io/task/pull/310
• https://github.com/Meeds-io/meeds/pull/1264
• https://github.com/Meeds-io/wallet/pull/442

@boubaker

[boubaker]

PR ready for review & Mips ACC updated

Thanks, reviewed.

[boubaker]

All PRs approved. Have a nice weekend 👍