Closed srenault-meeds closed 11 months ago
@margondicco Can you please take a look at it please? We started to work it as enhancements but we suggest to make it a MIP to make sure you can take it into account.
Hello ok cc @Julien-Dubois-eXo
Thanks Go-Fonc added
Ready for tech review by DAO members (eXo: @rdenarie )
Go tech
Accs & PRs ready to review by DAO members (eXo : @rdenarie )
Accs & PRs ready to review by DAO members (eXo : @rdenarie )
A new PR for automatic tests adoption has been added as well.
All pr validated
All pr validated
Thanks @rdenarie , can you please review again https://github.com/Meeds-io/notes/pull/779 A modification is made due to a rebase conflict
All pr validated
Thanks @rdenarie . All PRs merged.
Rationale
Two concerns regarding the snackbar:
Mobile:
Desktop:
1. Functional Requirements
Top User Stories
Desktop:
Text:
If CTA link
Close icon
Snackbar style:
Mobile
Impacts
Any existing snackbar must use this component
Gamification
NA
Notifications
NA
Analytics
NA
Unified Search
NA
2. Technical Requirements
Extensibility
The Toast notification component is added globally in all pages with a single instance and can be called using directives:
This flexibility will be kept and we will have just to rework all existing notifications to re-use this component through the existing API.
Upgradability
An cleanup of existing alerts has to be made to reuse this component through existing API. In addition, the overridden style of
v-alert
will have to be removed to allow usingv-alert
as predefined in Vuetify.Feature Flags
No feature flag.
4. Software Architecture
Access
All snackbar alerts in all Meeds modules will have to be removed in favor of this component in order to centralize the UX for a better maintainability and product design evolution. In addition, the existing overridden
v-alert
style of Vuetify will have to be removed to allow usingv-alert
in page. The current Snackbar z-index has to be reviewed as well to make it on top of all UI components.