Meeds-io / meeds

The Meeds Association provides its members with an employee recognition software implementation. The employee recognition software is fueled by the Meeds ERC-20 tokens.
https://meeds.io
GNU Lesser General Public License v3.0
281 stars 9 forks source link

[NewsList] Cannot manage newslist target if not in content-management but admin #2459

Open srenault-meeds opened 2 weeks ago

srenault-meeds commented 2 weeks ago

Steps to reproduce

Steps to reproduce the behavior:

  1. As platform admin, but not content-manager (no permission in group web-contributors)
  2. Access the newslist target management
  3. Edit a target
  4. Add permissions
  5. Save
  6. See error: it doesn't work because the admin is not in the group web-contributors Edit target of newslist

Expected behavior

Consider platform admin (* in platform/admin) as the super user so he can manage targets as expected

srenault-meeds commented 2 weeks ago

FYI @Julien-Dubois-eXo

Julien-Dubois-eXo commented 1 week ago

@srenault-meeds I agree, it's better to use platform/admin to centralize all admin permissions instead of several groups. This was done on purpose, as before, all the features related to content management were web-contributor. So maybe it's more an improvement rather than a bug.

srenault-meeds commented 1 week ago

ok. Do you plan to improve it? Thanks

Julien-Dubois-eXo commented 1 week ago

From what I know it's not part of the scope now. I asked @margondicco if I should include this point and the other about target permission by default on the MIP161.