Meeds-io / meeds

The Meeds Association provides its members with an employee recognition software implementation. The employee recognition software is fueled by the Meeds ERC-20 tokens.
https://meeds.io
GNU Lesser General Public License v3.0
283 stars 9 forks source link

[bug] [ANALYTICS] space host have access to action menu of analytics page #2585

Open mkrout opened 1 week ago

mkrout commented 1 week ago

Rationale An analytics portlet (rate, table, chart) can be integrated into a space page to allow space animators or members to consult data on activities in the space.

Analytics provide very precise information on user usage. It is essential to be able to limit the use of these analytics by blocking the possibility of edit settings and view samples of the portlets

requirements

As a user with space permissions : "Edit navigation" Then the user can edit the portlet, json and view samples (all the options in the 3 dots)

As a user without space permission : "Edit navigation" Than the user cannot edit the portlet, json and view samples (all the options in the 3 dots)

image

boubaker commented 1 week ago

Not a bug, since this is an expected behavior, thus requalified to Feature enhancement project instead. Thanks for your understanding.

margondicco commented 1 week ago

Hello, @Jihed525 , after discussion with Meeds lab, it wasn't an issue. So we should do a roll back.

I wrote the new requirement here

cc @mkrout @srenault-meeds

Thank you

srenault-meeds commented 1 week ago

If I may, here is a more detailed expectation:

Platform admins, Space Coordinator (AKA SuperManager) can edit navigation and thus, these users can access analytics settings: view samples, edit settings, edit json settings

If for permission: "Edit navigation", Space admins or Group members are identified in space template configuration, OR in space permissions as allowed to use such permission Then , they can access analytics settings (view samples, portlet edition, json edition) if they can edit navigation as well

If no specification for navigation permission in space template OR space permission, then space admins cannot access analytics settings

mkrout commented 1 week ago

Hello, @Jihed525 , after discussion with Meeds lab, it wasn't an issue. So we should do a roll back.

I wrote the new requirement here

cc @mkrout @srenault-meeds

Thank you

Reverted