Meeds-io / meeds

The Meeds Association provides its members with an employee recognition software implementation. The employee recognition software is fueled by the Meeds ERC-20 tokens.
https://meeds.io
GNU Lesser General Public License v3.0
281 stars 9 forks source link

deleted spaces displayed in analytics space board #428

Open hthabti opened 1 year ago

hthabti commented 1 year ago

version: 6.4/6.3

Steps to reproduce user1 create spaceX in the plf make some activities on it delete it as user having a role in "platform/administration" or in "analytics administrators" group open analytics app> space analytics>

Current behaviour deleted spaces are displayed in analytics space board

screencast: https://youtu.be/l2WSHV5XD_Q

Expected behavior deleted spaces shouldn't be displayed

Feedback https://community.exoplatform.com/portal/dw/forum/topic/topic950091fbac1200117189f89ca1907462

related task on exo https://community.exoplatform.com/portal/dw/tasks/taskDetail/60909

srenault-meeds commented 1 year ago

Please we shouldn't take care of that this following: don't display deleted spaces But the following way:

cc @margondicco

margondicco commented 1 year ago

a

Please we shouldn't take care of that this following: don't display deleted spaces But the following way:

  • If space admin (ability to manage spaces in manage spaces feature), then I can see label of spaces (not clickable with a tooltip - Deleted space)
  • If not space admin, then deleted spaces should be displayed but with no label as I can't see it. IMO We should still view activities from spaces that have been deleted because during the selected period, activity has been done. Or analytics are wrongly computed and metrics are wrong.

cc @margondicco

agree