search

MeemeeLab / node-anime-viewer

Nodejs implementation of ani-cli.
Other
27 stars 6 forks source link

make it usable as installable cmdline tool #3

Closed asdfugil closed 2 years ago

asdfugil commented 2 years ago

npm i -g asdfugil/node-anime

Tool will be available as command node-anime

also this does not seem to be licensed

MeemeeLab commented 2 years ago

This repository is licensed under Apache2.0 (Written in package.json), I'll add LICENSE file later

MeemeeLab commented 2 years ago

Looks like npm installable cmdline is working right without any code changes, And interface.js change causes error on windows. I'll close this PR, but I'll publish this package to npm registry.

MeemeeLab commented 2 years ago

I'm sorry, I was working on current directory that had package.json file... Anyways, This was fixed by #7.

asdfugil commented 2 years ago

Looks like npm installable cmdline is working right without any code changes, And interface.js change causes error on windows. I'll close this PR, but I'll publish this package to npm registry.

Make sure you are not testing inside of the source tree

Since current directory in fs.readFileSync() is thr working directory, not script path

asdfugil commented 2 years ago

Actually nevermind didn't see config.js