search

MegaAntiCheat / client-backend

GNU General Public License v3.0
119 stars 25 forks source link

Restructuring the code to support proper versioning. #78

Open StevenAlexanderJohnson opened 9 months ago

StevenAlexanderJohnson commented 9 months ago

I'm noticing in the Web portion of this repo that the versioning is being handled by adding "v1" to the URL. It is possible to create a router containing all v1 routes in a module then use that module as a "nest" router. This refactor would allow to scale the API with new versions easier, as once you sunset a version you can edit the v2 module without risk of editing the v1 code.

It would be a decent refactor so I'll wait for feedback on when this refactor should take place as to not create merge conflicts.

Bash-09 commented 8 months ago

This would be a totally reasonable change to make, any poor design decision on the web API side of things was probably me not knowing much about what I'm doing in that area lol.

I think it's probably not hugely consequential, but I wouldn't be opposed to such a change.