search

MegaAntiCheat / client-backend

GNU General Public License v3.0
118 stars 25 forks source link

Warn instead of Error if game not started #97

Closed megascatterbomb closed 8 months ago

megascatterbomb commented 8 months ago

Some users are confused by the looping rcon timeout errors that occur when the game is closed. This PR changes those errors to better communicate expected behaviour.   Other errors (such as 1st error in image) remain untouched. Rcon timeout errors (2nd and 3rd errors in image) are changed to warnings with guidance indicating that the warning is expected if TF2 is closed.

image

Bash-09 commented 8 months ago

A problem with this is that the error message are OS-dependent so checking for a hardcoded string will not be effective everywhere. I plan to look at improving the error handling which will give us a means to handle this better. For the moment I will just leave this PR here.

(e.g. on Ubuntu I get "Connection refused") image

megascatterbomb commented 8 months ago

Lilith has implemented better error reporting on his branch; so I'm going to close this PR.