MegaAntiCheat / masterbase

API/Data Platform for Ingesting, Storing, and Serving Data through Postgres, and Litestar
9 stars 1 forks source link

`late_bytes` management #69

Closed kavorite closed 3 weeks ago

kavorite commented 3 weeks ago

Allowing arbitrary data to be posted to the /late_bytes endpoint, which is currently neither subject to anomaly checks nor size limits, seems like asking for trouble. Posting to this endpoint should be less permissive, not more so.

The acceptance criteria that should close this are as follows:

kavorite commented 3 weeks ago

https://github.com/MegaAntiCheat/masterbase/blob/64ada88eff0d398ae229a44db2eeb8a31f00b126/masterbase/lib.py#L24-L25

https://github.com/MegaAntiCheat/masterbase/blob/64ada88eff0d398ae229a44db2eeb8a31f00b126/masterbase/lib.py#L491-L493

oh. it's ten bytes?

nevermind, and also I'll probably just buffer them in my implementation. Although: We should probably still make sure the length is a match