search

MegaArman / toscanini

A JavaScript module for searching music scores.
https://megaarman.github.io/toscanini
MIT License
16 stars 3 forks source link

Dynamics not comprehensive enough #47

Closed galinabee closed 7 years ago

galinabee commented 7 years ago

The getDynamics of toscanini does not include crescendo, diminuendo. Take a look at basiccres.xml to see the difference in the score to basic.xml - direction-type - wedge.

galinabee commented 7 years ago

If the crescendo or diminuendo is in the score as a text, it would be nearly impossible to find it, unless we were to search through for a word attribute and include possibilities such as dim., diminuendo, etc.

galinabee commented 7 years ago

There's a general grading of dynamics in the grading file, no test files yet, and I'll work on incorporating the inside of the tag.

galinabee commented 7 years ago

Double check the insides of the object, values should be in there.