MegaGameSociety / WatchTheSkiesDashboard

Watch the Skies Dashboard
1 stars 2 forks source link

User Enhancements #49

Closed michaelpelletier closed 8 years ago

michaelpelletier commented 8 years ago
FifthSurprise commented 8 years ago

The reason edit/new isn't working is because your form routes to Users::RegistrationsController instead of UsersController. This is because Devise gem overrides the registration process to handle that. I think removing that override in the routes.rb:7 might be the easy fix but it might not be...

FifthSurprise commented 8 years ago

Okay I'm done for now. I'll poke around some more once we settle down on schema changes.

michaelpelletier commented 8 years ago

@FifthSurprise - I didn't remove the seed data for countries yet because I'm not sure how we want to handle it, but I did add views (that work!) for adding other countries.

I am not sure what these lines are meant to do, so I am not sure if they still work - https://github.com/MegaGameSociety/WatchTheSkiesDashboard/blob/develop/app/controllers/games_controller.rb#L30

I also am having an issue with this where creating a User doesn't seem to work - it redirects to the Splash Page.

Other than those two things, this should possibly be finished!

FifthSurprise commented 8 years ago

Those lines represent the conversion of income level to the # of credits they receive. It's different per country and should probably get moved into the Team Structure/Seed Data at some point. I'll make a separate ticket for this.

michaelpelletier commented 8 years ago

Oh, I didn't know that was a thing, but that makes sense. I suppose that will need to be included into the Team Creation structure as well.

michaelpelletier commented 8 years ago

Opened https://github.com/MegaGameSociety/WatchTheSkiesDashboard/issues/51 to follow-up on some of the future enhancements to the Team Creation feature introduced in this pull request.