search

MegaGlest / megaglest-source

MegaGlest real-time strategy game engine (cross-platform, 3-d)
http://megaglest.org/
355 stars 90 forks source link

If Windows installer applied network throttling fix, request reboot #113

Open tomreyn opened 8 years ago

tomreyn commented 8 years ago

When the Windows installer needs to apply the network throttling fix (and only then), the installer should prompt the user to reboot the system after the game installation completes so as to apply the registry change.

The same should happen during uninstallation (since then the registry change needs to be undone).

filux commented 8 years ago

Hehe when I was on windows such "senseless reboots" were one of most annoying things :) ... so few questions:

tomreyn commented 8 years ago

do we really need reboot?

There is no other way to apply the registry change (that I am aware of). Maybe restarting all networking services or bringing network interfaces down and up again does it, but I doubt it.

do we really need "undone"? until now I thought about about this as a "fix" for some another "great idea" from microsoft

From what I read Ms introduced this registry setting to work around an issue in their OS where the network stack makes video playback / recording stutter / stall. So you can choose between delaying network traffic (Microsofts default) and possibly causing stuttering playback / recording of networked media streams (our choice).

I think it would be good to restore the default value when rolling back the MegaGlest installation, this would be my expectation as a user.

what is default value of this key? and does it is always same/constant value or may have ~ few values?

By default, this registry key does not exist, in which case Windows Vista defaults to a value of 10 according to https://support.microsoft.com/en-us/kb/948066 - I assume that's the same for other Windows releases. I assume the value is usually static.

titiger commented 8 years ago

I personally don't think that this registry change really helps with MG. I tried several things, and I never saw any difference. We have no shooter, where every ms counts, so it does not really matter. Did you ever saw a real difference with or without this setting ?

tomreyn commented 8 years ago

Personally I don't play much on Windows so I could hardly tell. Maybe someone else can, or @softcoder could discuss it.

tomreyn commented 7 years ago

Related to #117

biels commented 7 years ago

I've noticed this stalling effect on MG 3.12 while playing a LAN game over a wifi network with poor performance. However, the effect was noticeable on both windows (Windows 7) and linux (Kubuntu). This might be related to this issue. Shouldn't the game rendering be completely detached from the network stream/synchronization?

titiger commented 7 years ago

@biels no the game is not detached form the network. If a needed network package does not arrive, the game has to wait until it knows what to do. If you have those freezes while playing on LAN/Wlan the reason most likely is wacky WLAN connection, or slow hardware on one of the machines. If for example the server falls back this will always make freezes on the clients.