search

MegaGlest / megaglest-source

MegaGlest real-time strategy game engine (cross-platform, 3-d)
http://megaglest.org/
349 stars 89 forks source link

Update intro.cpp #124

Closed andy5995 closed 8 years ago

andy5995 commented 8 years ago

Fixing typo in variable name. It also needs to be changed in intro.h

filux commented 8 years ago
  1. You can find a looot such typos in variable names... so fixing them all may take some time... : )
  2. Sometimes fixed version may conflict with something or be backwards incompatible with something.
  3. Why this PR is not together with #125 as it is "one job"? There is possible to put single commit as PR or multiple commits... and ofc in single commit you can change multiple files too : D
  4. Looks like travis found some problems with those changes.
andy5995 commented 8 years ago
  1. I edited through the web, and didn't know that I could put it together with #125
andy5995 commented 8 years ago

Yup. Looks like Travis tried building before intro.h was merged.

And #125 failed because #124 wasn't merged yet.