MegaGlest / megaglest-source

MegaGlest real-time strategy game engine (cross-platform, 3-d)
http://megaglest.org/
348 stars 89 forks source link

map editor - undo function sometimes does not work #148

Closed andy5995 closed 7 years ago

andy5995 commented 7 years ago

For certain features, using undo from the edit menu doesn't produce expected results:

  1. If a player's position is changed, and undo is immediately used, clicking undo does nothing
  2. if randomize height is used 1x, undo does nothing unless clicked 2x
  3. If the map is resized, and undo is immediate used, it does nothing.
titiger commented 7 years ago
  1. is known and will not be fixed ( its a bit complicated and I see no real benefit )
  2. is fixed
  3. In my eyes 3 should be a full reset and its ok you cannot undo it in my opinion. Problem is currently its not a full reset. ( I see no benefit to keep a part of the map in editor when resizing ).
titiger commented 7 years ago

I vote to remove the resize possibility. Just use "new" to start a map of different size. Real resize makes no sense in my opinion.

andy5995 commented 7 years ago

I could adjust to that; new -> size. I vote ok if it makes things easier

andy5995 commented 7 years ago

@titiger fixed this with https://github.com/MegaGlest/megaglest-source/commit/da48cfe9ce51e6c518fc1f2df99f0479aa88a860

Closing.