search

MegaMark16 / django-cms-themes

A way to quickly load and swap out template packs (or themes) for Django CMS
BSD 3-Clause "New" or "Revised" License
49 stars 15 forks source link

Fixes from nephila/django-cms-themes #5

Closed hsk81 closed 12 years ago

hsk81 commented 12 years ago

Hi Mark,

I took the liberty to send you nephila's fixes as a pull request. I'd trouble with issue #3 which nephila seems to have fixed, but I did not see any corresponding pull request from his side.

In addition have added one "fix" on my own which tells the OS environment to use Python 2 instead of Python 3; I don't know if some (older) setups will have trouble with

#!/usr/bin/env python2

but if so just ignore my related commit 95af1be2d31685eca899549fe9656b137cedcf96.

yakky commented 12 years ago

Yes, basically i didn't requested pull for the commits because i feel it's a very ugly hack, but I haven't had time to find a better solution since then.

hsk81 commented 12 years ago

So you think I should close the pull request? Still think your tweak has value .. it solved my problem.

yakky commented 12 years ago

I'm still +1 I commited because it solves a problem, and it's one step in the right direction. So I do hope MegaMark16 would accept this.

MegaMark16 commented 12 years ago

Thanks @hsk81 and @nephila, sorry it took so long for me to get around to merging the fix, but it works like a charm, and honestly the whole thing is kind of a hack, so it fits right in :-)

Thanks! Mark