MegaMek / megamek

MegaMek is a networked Java clone of BattleTech, a turn-based sci-fi boardgame for 2+ players. Fight using giant robots, tanks, and/or infantry on a hex-based map.
http://www.megamek.org
GNU General Public License v2.0
299 stars 288 forks source link

48.0 Incorrect DropShip bay capacity increase when importing from MUL with pre-loaded units #2976

Open gsparks3 opened 3 years ago

gsparks3 commented 3 years ago

Description

Importing a MUL that includes a DropShip with pre-loaded units seems to cause the DS to appear with its standard complement of available bays - meaning that it actually has additional bay space to accommodate the pre-loaded units, which persist if the units are unloaded, giving the DS up to twice as much bay space as it should have.

Reproduction steps:

  1. Import the provided MUL with no units loaded onto the Leopard. Note that they can be loaded onto the Leopard normally and it will show no capacity remaining once fully loaded.
  2. Import the provided MUL with the Leopard fully loaded. Note that upon using "View" panel it will still show 4 mech bays and 2 ASF bays available, despite 4 mechs and 2 ASF already being loaded. Unload all units and note that the available bays has now increased to 8 mechs and 4 ASF.
  3. If desired, import the "half loaded" MUL and observe similar behavior to the above, except the Leopard now has 6 mech bays and 3 ASF bays when unloaded.

Files

MULs of a Leopard plus four Locusts and two Sparrowhawks are included for ease of testing. One has the units pre-loaded into the Leopard, one has them fully unloaded, and one has half the units loaded and half unloaded. DSmuls.zip

pheonixstorm commented 1 year ago

This issue sounds similar to what I ran across when adding the TacOps BA weights option. #46