MegaMek / megamek

MegaMek is a networked Java clone of BattleTech, a turn-based sci-fi boardgame for 2+ players. Fight using giant robots, tanks, and/or infantry on a hex-based map.
http://www.megamek.org
GNU General Public License v2.0
297 stars 287 forks source link

Specialty Armor for ASF and damage Thresholds #3396

Open Logion567 opened 2 years ago

Logion567 commented 2 years ago

Fill out the fields below with as much pertinent information as possible to help the developers solve the issue. Search for your issue inside open and closed issues first before reporting so as not to make duplicates. (Delete the above lines)

Environment

MM version .49.5

Description

Specialty Armors for ASF still trigger Damage Thresholds critical checks for their respective damage type. image this forums post says that only damage counted in the record sheet/against the armor after damage reduction counts for these thresholds https://bg.battletech.com/forums/total-warfare/(answered)-prevented-or-reduced-damage-and-psr/

Files

DAMAGE.sav.gz the overall setup is there for ease of testing, should give plenty of room for figuring out how the logic is breaking

My Name is Logion567 (as seen in the screenshot)

HammerGS commented 2 years ago

Related to https://github.com/MegaMek/megamek/issues/2032