MegaMek / megamek

MegaMek is a networked Java clone of BattleTech, a turn-based sci-fi boardgame for 2+ players. Fight using giant robots, tanks, and/or infantry on a hex-based map.
http://www.megamek.org
GNU General Public License v2.0
299 stars 288 forks source link

[49.8] Heavy Medium Laser Requires 2 Weapon Slots on Aerospace Fighter ASF #3700

Closed PhoenixHeart512 closed 5 months ago

PhoenixHeart512 commented 2 years ago

Environment

Build Date: 2022-05-27T12:45:51.888427300
Release Date: 2022-02-18
Today: 2022-06-07
Origin Project: MegaMekLab
Java Vendor: Eclipse Adoptium
Java Version: 11.0.14.1
Platform: Windows 10 10.0 (amd64)
System Locale: en_US
Total memory available to MegaMekLab: 8 GB

Description

MegaMekLab shows that the Heavy Medium Laser requires 2 weapon slots on Aerospace fighters, but TechManual says it only requires 1 slot (TM p. 343).

Files

Screenshot: HML ASF

HammerGS commented 2 years ago

Doing some digging (and don't remember seeing this before) but looks like ASF's pull the Mechslots. I think we need an AeroSlots like our Tank and SV Slots. If I'm missing something please point it out. (It's before the morning caffeine has kicked in)

PhoenixHeart512 commented 2 years ago

Did some quick tests in meklab, and this behavior is different than I originally thought. Weapon slot size has nothing to do with this.

(As a result of your comment, I did check and all of the weapons show mech sized slots, but the ASF properly ignores that slot size when building it out, even for HML's)

Whatever is not allowing me to add a 4th weapon to the wing slot is not because of the weapon size of the weapon. I am unable to add any weapons to that slot, and when I pull up a new unit and modify from scratch it allows me to put 4 HML's in a single location. Something is causing MML to think that there are already 4 weapons in that section.

I need to do some more digging on this, but for the time being this can be marked inactive or "needs verification" if there are any status states like that.

There is something wrong, and it's not what I thought, but I don't fully know what it is yet or what the exact conditions for it to happen are.

PhoenixHeart512 commented 5 months ago

This one appears to have been fixed with all the mechlab changes that have occurred between 49.8 and 49.19 and can probably be closed @HammerGS