search

MegaMek / megamek

MegaMek is a networked Java clone of BattleTech, a turn-based sci-fi boardgame for 2+ players. Fight using giant robots, tanks, and/or infantry on a hex-based map.
http://www.megamek.org
GNU General Public License v2.0
297 stars 287 forks source link

Partial Wings problem #4081

Open SJuliez opened 1 year ago

SJuliez commented 1 year ago

0.49.12:

When configuring damage in the lobby and marking off even a single crit of a PW, it no longer confers a heat dissipation bonus and seems to count as destroyed, at least according to the MechView. (See Mech.getHeatCapacity(). The code dealing with remaining PW crit slots is not reached when it is destroyed) According to TO:AUE p.105 a PW loses jump bonus with crits but can stay functional and the heat bonus does not depend on crits but only requires the PW to be "functional".

It's a bit difficult to test but the bug could also occur when the PW is damaged during a game.

kuronekochomusuke commented 1 year ago

looks like the lobby damage editor sets it to destroyed, if there is any damage assigned. would probably be hard to determine generically how many hits it takes to destroy it.

Entity.damageSystem image

it also applies a hit to each location if the component if split across multiple locations. instead of just applying one hit to one of the locations.

SJuliez commented 1 year ago

Yes, and the relevant part in GameManager has special treatment for Mek Shields at least but not PWs. I am trying to get Super-Cooled Myomer functional in MM (currently construction-only) and was trying to see how similar gear is treated so as not to reinvent the wheel. Seems there's issues (no real wheel present) so I thought I'd add this issue.