MegaMek / megamek

MegaMek is a networked Java clone of BattleTech, a turn-based sci-fi boardgame for 2+ players. Fight using giant robots, tanks, and/or infantry on a hex-based map.
http://www.megamek.org
GNU General Public License v2.0
299 stars 291 forks source link

[0.49.17] MM Infantry C-Bill Cost Bugs #5056

Open jasonf529 opened 10 months ago

jasonf529 commented 10 months ago

Environment

v0.49.17 Windows 10 Java Version: 11.0.20.1

Description

The following are issues with C-Bill cost calculations for conventional infantry. These are issues related to the calculation formulas themselves, and not any missing equipment, infantry specializations, etc.

  1. Jump Infantry [all unit sizes and subvariants]: incorrectly multiplies base C-Bill cost by 5x (should have no cost multiplier).
  2. Motorized Platoon (Flamer), (MG), (LRM), (Rifle), (Laser), (SRM): incorrectly multiplies base C-Bill cost by 5x (should have no cost multiplier).
  3. Motorized Platoon (Taurian) / (Flamer), (MG), (LRM), (Rifle), (Laser), (SRM): incorrectly multiplies base C-Bill cost by 5x (should have no cost multiplier).
  4. Motorized Squad (Flamer), (MG), (LRM), (Rifle), (Laser), (SRM): incorrectly multiplies base C-Bill cost by 5x (should have no cost multiplier).
  5. Clan Motorized Point [all subvariants]: incorrectly multiplies base C-Bill cost by 5x (should have no cost multiplier).
  6. Clan Motorized Squad [all subvariants]: incorrectly multiplies base C-Bill cost by 5x (should have no cost multiplier).
  7. Beast Infantry [all beast types and subvariants]: incorrectly multiplies base C-Bill cost by 4.5x (Branth) or 5x (all others) (cost multiplier should be 5000 C-Bills x total platoon tonnage, TO:AUE, p. 225).
  8. XCT-Trained Infantry [all types and conditions]: XCT condition-trained troops should use 1.5x cost multiplier (not 5x) [TO:AUE, p. 225]

I could not completely confirm that these two are bugs, but from what I could tell, the costs should be subject to all other final cost multipliers for the relevant infantry units [TO:AUE, p. 225, table footnote]

  1. Beast Infantry [all beast types and subvariants]: all (final) cost multipliers applied prior to including beast C-Bill cost in total unit cost.
  2. Field Weapons [all types and subvariants]: all (final) cost multipliers applied prior to including weapon (and ammo) C-Bill cost in total unit cost.
HammerGS commented 10 months ago

The x5 comes from a skill level indicates they have Anti Mech training.

SJuliez commented 10 months ago

I believe we have a problem here in that we don't separately store the fact that a CI has anti-mek gear