MegaMek / megamek

MegaMek is a networked Java clone of BattleTech, a turn-based sci-fi boardgame for 2+ players. Fight using giant robots, tanks, and/or infantry on a hex-based map.
http://www.megamek.org
GNU General Public License v2.0
297 stars 286 forks source link

RFE: Ejection Warning in vacuum and hostile environments #5579

Open VictorMorson opened 4 months ago

VictorMorson commented 4 months ago

Environment

Build Date: 2024-04-19T14:55:55.050537200
Today: 2024-06-16
Origin Project: MegaMek
Java Vendor: Eclipse Adoptium
Java Version: 11.0.15
Platform: Windows 10 10.0 (amd64)
System Locale: en_US
Total memory available to MegaMek: 8 GB

Description

I am making this request largely because there are already warnings for vacuum, when attempting to take an illegal vehicle onto the map; as an extension of that I am proposing a warning when your Auto-Ejection is set to On in a lethal environment.

It is very easy to forget that auto-ejection is enabled and launch onto a map only for the pilot to eject to their certain doom in survivable situations (such as a gauss rifle exploding). It'd be very nice to have a "Some units have Ejection enabled, do you wish to continue?" safety check in there.

ramgarden commented 3 months ago

I'm trying to find where in the code this happens. Can you put a screen shot or paste the text in here that it shows for the warning? I could try to reproduce it myself but if you can get to it quicker that would be helpful to find where this happens so I can make it happen for other places. Or, is it as simple as just checking for this auto-eject flag and if it's set, show the warning before ejection happens?

repligator commented 3 months ago

I'm trying to find where in the code this happens...

megamek/client/ui/swing/lobby/LobbyMekCellFormatter.java (Line 127) megamek/client/ui/swing/DeploymentDisplay.java (Line 315)