MegaMek / megamek

MegaMek is a networked Java clone of BattleTech, a turn-based sci-fi boardgame for 2+ players. Fight using giant robots, tanks, and/or infantry on a hex-based map.
http://www.megamek.org
GNU General Public License v2.0
296 stars 286 forks source link

[0.50.0 build of July 4th] Some client settings do not save properly #5694

Open SirChaos1 opened 3 months ago

SirChaos1 commented 3 months ago

Some client settings do not save properly, and instead reset to default the next time MegaMek is launched.

The settings I´ve experienced this with are keymaps (Next Weapon in particular, as that´s the only one I´ve changed so far) and the Auto Display setting for the minimap.

A lot of other settings do save properly, including Show Wrecks and (strangely enough) the Auto Display setting for the player list.

The location, but not the size, of the minimap also resets to the default, whereas unit display and round report stay where I put them.

I´ve been launching MegaMek from MekHQ, not directly.

gsparks3 commented 3 months ago

I can confirm that the Auto Display - Minimap client setting resets after closing and re-opening the Megamek client in the previous 49.20 release as well. I am launching Megamek directly.

I also find that the minimap maintains its position, while the round report resets its position (the opposite of what you saw), although both seem to maintain their size.

Thom293 commented 3 months ago

Sort of related: https://github.com/MegaMek/mekhq/issues/3976

SirChaos1 commented 3 months ago

FWIW the issue happens exactly the same when I launch MM directly, not through MHQ.

repligator commented 3 months ago

@SirChaos1 @gsparks3 Can you please post your operating system (Windows, OS X, or Linux)?

gsparks3 commented 3 months ago

I'm on Windows 10.

SirChaos1 commented 3 months ago

Windows 10 as well.

kuronekochomusuke commented 2 months ago

when you see these issues does the mmconf\clientsettings.xml file get updated?

I put in a fix for the auto display one

gsparks3 commented 2 months ago

Hmm. Testing shows that the round report and minimap seem to be remembering their positions for me now in 49.20. Not sure why it was resetting before ...

Thanks for the minimap auto-display fix!