search

MegaMek / megamek

MegaMek is a networked Java clone of BattleTech, a turn-based sci-fi boardgame for 2+ players. Fight using giant robots, tanks, and/or infantry on a hex-based map.
http://www.megamek.org
GNU General Public License v2.0
299 stars 288 forks source link

Weapon Handler Comment cleanup #6025

Closed SJuliez closed 1 month ago

SJuliez commented 1 month ago

This is 99% comment cleanup in the weapon handler classes, removing those "non-javadoc"s, updating the copyrights, removing empty javadocs (I didnt bother filling in the constructor javadocs, as they mostly just call super). And maybe 3 minor and obvious code updates.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 29.10%. Comparing base (db1a9a3) to head (b8ce280). Report is 12 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #6025 +/- ## ============================================ - Coverage 29.10% 29.10% -0.01% + Complexity 13973 13972 -1 ============================================ Files 2580 2580 Lines 267140 267143 +3 Branches 47709 47711 +2 ============================================ - Hits 77744 77743 -1 - Misses 185499 185502 +3 - Partials 3897 3898 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rjhancock commented 1 month ago

If there is a variable in the parent class with the same name, they don't need to be redeclared and can cause issues