Custom Infantry Armor Types and Divisors do not work properly.

BrandonSmith16 commented 3 weeks ago

Prerequisites and Pre-Issue Checklist

[X] I'm reporting the issue to the correct repository:
MegaMek
MegaMekLab
MekHQ
[X] I've tested the issue against at least the latest MILESTONE version
[X] I've asked on the MegaMek Discord about the error
[X] I've reviewed the BattleTech rules and MegaMek documentation, and I've confirmed that something isn't working as intended.
[X] I've searched the Github tracker and haven't found the issue listed

Severity *

Medium (Gameplay Limitation): Non-core functionality is impaired, providing a suboptimal but playable experience.

Brief Description *

As of now custom armor divisors don't register at all in megamek or mekhq and custom armor types only sort of register properly in megmeklab.

You can only use them in megameklab if you use the following workaround: First you remove the armor using the remove armor button. Then you select an existing "donor" armor type in the stats sheet, then select use custom. It won't allow you to apply the custom armor without selecting a base armor in the stats menu. Trying to add special armor abilities like camo now won't work. To get the custom armor types to register you have to first click the "add armor" button then select the special types. The custom divisor won't work at all it will only ever use the divisor of the base armor you selected in the stats menu. The partially custom armor can be saved to the .blk and will load in megameklab just fine after this, even if the divisor doesn't work.

However it won't import the custom armor into megamek, just the donor armor. MekHQ will display the purchased custom unit correctly until you assign soldiers to it, then it will behave the same as megamek, only displaying the divisor and abilities of the base armor.

Finally, once in megamek, attempting to select a custom armor type will not use the divisor you type in instead defaulting to some value whenever you select a special armor ability. The abilities selected will however persist.

Steps to Reproduce

In order to find the bug in mekhq you have to purchase a unit with custom armor created via the workaround and then assign a unit. it will import properly but it will reset the armor to the base type and stats of the base armor once you assign soldiers.

in order to reproduce the bug in megamek you merely need to load an infantry unit of any kind and attempt to assign a custom armor.

Operating System *

Windows 10

Java Version *

17.7

MegaMek Suite Version *

v0.50.0

Custom MegaMek Version

No response

Attach Files

No response

Final Checklist

[X] I've checked to make sure that this issue has not already been filed
[X] I'm reporting only one issue in this ticket for clarity and focus

HammerGS commented 2 weeks ago

What do you mean by "custom armor types" Do you have screenshot.

BrandonSmith16 commented 2 weeks ago

I mean if you were to try to create a suit with say an ecm lining and an armor divisor of 2. DEST/Space/ECM/IR etc etc.

On Wed, Oct 16, 2024 at 10:50 AM Dave N @.***> wrote:

What do you mean by "custom armor types" Do you have screenshot.

— Reply to this email directly, view it on GitHub https://github.com/MegaMek/megamek/issues/6090#issuecomment-2417387058, or unsubscribe https://github.com/notifications/unsubscribe-auth/BAUEWJIC4LU4TRID5LXU7LLZ32KNZAVCNFSM6AAAAABPZH3LKOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJXGM4DOMBVHA . You are receiving this because you authored the thread.Message ID: @.***>

gsparks3 commented 2 weeks ago

What do you mean by "custom armor types" Do you have screenshot.

For reference - in 0.50 MegaMekLab, custom armor kits can be defined:

You can also Configure a custom armor kit in the MegaMek lobby:

~~@BrandonSmith16 Was this specifically the "Configure in lobby" option having issues, or a pre-generated unit with a custom armor kit, or both?~~ Perhaps if I actually read the report instead of only responding to the more recent comments I would see that my question had already been answered. Looks like both have issues, in slightly different ways.

BrandonSmith16 commented 2 weeks ago

It was both.

On Wed, Oct 16, 2024 at 9:14 PM gsparks3 @.***> wrote:

What do you mean by "custom armor types" Do you have screenshot.

For reference - in 0.50 MegaMekLab, custom armor kits can be defined: image.png (view on web) https://github.com/user-attachments/assets/8522ae5c-6268-4163-adc3-c8c39c019a25

You can also Configure a custom armor kit in the MegaMek lobby: image.png (view on web) https://github.com/user-attachments/assets/005b5baf-4604-4586-823b-100c72221165

@BrandonSmith16 https://github.com/BrandonSmith16 Was this specifically the "Configure in lobby" option having issues, or a pre-generated unit with a custom armor kit, or both?

— Reply to this email directly, view it on GitHub https://github.com/MegaMek/megamek/issues/6090#issuecomment-2418407933, or unsubscribe https://github.com/notifications/unsubscribe-auth/BAUEWJMXDFGFLMGHJRE2VMTZ34TSLAVCNFSM6AAAAABPZH3LKOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJYGQYDOOJTGM . You are receiving this because you were mentioned.Message ID: @.***>

MegaMek / megamek