search

MegaMek / megameklab

MegaMekLab is a BattleTech unit modification program. It allows creating and modifying all unit types available in MegaMek from Support Vehicles up to WarShips. It also allows printing record sheets for single or multiple units.
http://www.megamek.org
83 stars 122 forks source link

MekLab is counting armor crit slots as extra tons of armor when costing units #1502

Closed sirbayer closed 2 months ago

sirbayer commented 2 months ago

Environment

MekLab 0.49.19 Windows Java SDK 17.0.10 (64-bit)

Description

When MekLab is calculating the CBill cost for a given unit, it is incorrectly calculating the price, because it is counting all the crit slots of armor as instances of that same type of armor. This is most easily viewed on the King Crab KGC-000: image image image The cost of this incorrect line-item appears to be equal to the cost of that tonnage of armor (e.g. 14 tons of Ferro-Fibrous armor does, in fact, cost 280,000 CBill). This also happens on units with Standard armor, and even Stealth, but those only count as one slot. This doesn't seem to be an omni-present issue - I didn't observe it on combat vehicles, at the very least.

Gribbly1 commented 2 months ago

Similar issue with BA

image

Gribbly1 commented 1 month ago

Looks like the fix removed ammo costs from units.

gsparks3 commented 1 month ago

Where are you looking for ammo costs? IIRC, MML always calculates "dry costs" nowadays (no ammo). However, MekHQ I believe should include them.

Gribbly1 commented 1 month ago

Comparing to 49.19