search

MegaMek / megameklab

MegaMekLab is a BattleTech unit modification program. It allows creating and modifying all unit types available in MegaMek from Support Vehicles up to WarShips. It also allows printing record sheets for single or multiple units.
http://www.megamek.org
86 stars 133 forks source link

Add missing 'CHASSIS' key to some Thunderbolt MTF files #1564

Closed juk0de closed 4 months ago

juk0de commented 4 months ago

This PR adds the string CHASSIS to the systemmanufacturer key of the following MTF files:

I encountered this issue while working on my MTF to JSON converter. Initially, I thought it was just an inconsistency, but these eight files are the only biped mech files missing the CHASSIS string. Therefore, I believe it is an ordinary bug, so I decided to fix it.

IllianiCBT commented 4 months ago

Congratulations on your first PR for this project!

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.52%. Comparing base (78b9c66) to head (1e50c58). Report is 7 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1564 +/- ## ======================================== Coverage 0.52% 0.52% Complexity 49 49 ======================================== Files 265 265 Lines 30440 30440 Branches 5182 5182 ======================================== Hits 160 160 Misses 30239 30239 Partials 41 41 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

HammerGS commented 4 months ago

I'll merge this, but for future reference all units file (BLK/MTF) are managed via MegaMek repo.

juk0de commented 4 months ago

I'll merge this, but for future reference all units file (BLK/MTF) are managed via MegaMek repo.

Understood :+1: Will create the next MTF related PR against MegaMek. But the MTF files are fundamentally identical between MegaMek and MegaMekLab, right?

HammerGS commented 4 months ago

The master data repo is MegaMek and stays current. We only transfer the MM units to MML and MekHQ every few weeks and it's a manual process which is why we always use MM as the primary data repo.

juk0de commented 4 months ago

Sounds complicated... Do I have to make another PR against MegaMek for these changes or are you going to transfer them manually?

HammerGS commented 4 months ago

I’ve merged these and moved them the other way. In future make against MM