search

MegaMek / megameklab

MegaMekLab is a BattleTech unit modification program. It allows creating and modifying all unit types available in MegaMek from Support Vehicles up to WarShips. It also allows printing record sheets for single or multiple units.
http://www.megamek.org
86 stars 134 forks source link

Frameless sheets #1620

Closed pavelbraginskiy closed 1 month ago

pavelbraginskiy commented 2 months ago

Depends on #1598. Doesn't use any features from that PR per se, but it touches the same files, and this prevents merge conflicts. If that PR hasn't been merged yet, this commit is the one with all the code changes for this PR.

Adds an option to draw record sheets without frames, as requested by CGL. Support all the 'Mechs (Bipedal, Quad, Tripod, QuadVee, LAM, and SuperHeavy variants).

Since this feature isn't expected to be useful for our non-CGL users, the ISO paper and TO heat options disable frameless output entirely, and the row shading option produces bad output.

image image image image image

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 2.17%. Comparing base (f3645a6) to head (c1dd60e). Report is 42 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1620 +/- ## =========================================== + Coverage 2.15% 2.17% +0.02% - Complexity 205 209 +4 =========================================== Files 266 266 Lines 30638 30754 +116 Branches 5236 5259 +23 =========================================== + Hits 660 669 +9 - Misses 29825 29928 +103 - Partials 153 157 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rjhancock commented 1 month ago

If this has all of the changes in #1598 as well as CGL's request, Id' suggest closing the other and making this one be all of the changes.

pavelbraginskiy commented 1 month ago

If this has all of the changes in #1598 as well as CGL's request, Id' suggest closing the other and making this one be all of the changes.

The other one will close automatically if this one is merged, and merging the other one will update this one to only be the relevant commits. It's decently smart about it.