search

MegaMek / megameklab

MegaMekLab is a BattleTech unit modification program. It allows creating and modifying all unit types available in MegaMek from Support Vehicles up to WarShips. It also allows printing record sheets for single or multiple units.
http://www.megamek.org
86 stars 133 forks source link

Better display of radical heat sinking in RS #1621

Closed pavelbraginskiy closed 1 month ago

pavelbraginskiy commented 1 month ago

Closes #1584. Requires MegaMek/megamek#6033.

When a unit mounts optional heat sinking equipment (Coolant Pods, Radical Heat Sinks), the heat profile is unhelpful: the given Dissipation value is never actually correct, since it's an approximate average between the dissipation with the system on or off.

This PR makes the sheet display both the heat value with the system off, and with the system on.

Since official sheets do not use the Heat Profile record sheet option, this change does not affect official sheets.

Example sheets:

image image image

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 2.15%. Comparing base (f3645a6) to head (737990c). Report is 3 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1621 +/- ## ======================================== Coverage 2.15% 2.15% Complexity 205 205 ======================================== Files 266 266 Lines 30638 30638 Branches 5236 5236 ======================================== Hits 660 660 Misses 29825 29825 Partials 153 153 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.