MegaMek / mekhq

MekHQ is a java helper program for the MegaMek game that allows users to load a list of entities from an XML file, perform repairs and customizations, and then save the new entities to another XML file that can be loaded into MegaMek.
http://megamek.org
134 stars 171 forks source link

Repair and Replacements Review #3515

Open gsparks3 opened 1 year ago

gsparks3 commented 1 year ago

Running a review of the Master Repair Table (Campaign Operations, p. 205-207) for missing, inconsistent, or confusing items (both in the table itself, and any issues in MekHQ versus said table). This issue will be updated as I investigate further.

SuperStucco commented 1 year ago

It is unclear when the "Motive System" entry in the Vehicle Replacement table would ever be used. Motive crits are possible but covered by the "Motive System Hit" Repair entry, and there is no indication that the motive system ever becomes unrepairable under Diagnosis.

Would that apply to a failed repair check (by elite tech failing, or margin of failure) that destroys the item or renders it unrepairable by others?

gsparks3 commented 1 year ago

Would that apply to a failed repair check (by elite tech failing, or margin of failure) that destroys the item or renders it unrepairable by others?

Hmm. Failed repair checks don't destroy the item (only failed Replacement checks do, and only the part you're currently installing), but they do render whatever damage was supposed to be repaired unrepairable without outright replacement. So a failed Motive System Hit repair by an Elite team means you either live with it or replace the entire motive system. That does check out.

Saklad5 commented 1 year ago

A gyro swap is supposed to be Class D, but appears to be Class F in MekHQ.

gsparks3 commented 1 year ago

This issue is only for repairs and replacements of items in a specific design, not refits, although the refit data in MekHQ being outdated was another long-standing issue and it's good that you got it updated.