search

MegaMek / mekhq

MekHQ is a java helper program for the MegaMek game that allows users to load a list of entities from an XML file, perform repairs and customizations, and then save the new entities to another XML file that can be loaded into MegaMek.
http://megamek.org
133 stars 171 forks source link

Minor wording change for mass repair/mass salvage in activity log #3723

Open SuperStucco opened 1 year ago

SuperStucco commented 1 year ago

When mass repair/mass salvage is used, it reports in the activity log like this:

Mass Repair/Salvage complete for 4 units. 
- 4 units had no actions performed because there were no valid parts.

Units with no valid parts: 
- Vulcan VL-5T
- Shadow Hawk SHD-2K
- Phoenix Hawk PXH-1
- Shadow Hawk SHD-2H #2

There are still 4 parts that are not being worked on 4 units.

The wording about 'no valid parts' can be a bit confusing - when I first started using MRMS it took me a while to figure out that it wasn't doing things not because of no parts in the Warehouse or otherwise 'not valid'. Instead, it is reporting there are components that need repairs but don't match the MRMS settings.

I think this would be more clearly stated something like this:

Mass Repair/Salvage complete for 4 units. 
- 4 units had no actions performed because mass repair/salvage criteria was not met

Units with parts not being worked on: 
- Vulcan VL-5T
- Shadow Hawk SHD-2K
- Phoenix Hawk PXH-1
- Shadow Hawk SHD-2H #2

There are still 4 parts that are not being worked on.
repligator commented 4 months ago

As of the latest nightly, this issue is sort of, kind of, partially solved. There are now 3 different explanations for lack of repairs. %s unit%s had no actions performed because there were no valid parts. %s unit%s had no actions performed because there were no valid techs. %s unit%s had no actions performed because there were unfixable limbs and configured settings do not allow location repairs. However, a message for %s unit%s had no actions performed because minimum BTH could not be reached with max available tech. is missing, despite there being an equivalent message in the debug log. Unfortunately, implementing such a message is beyond my skill, unassigning myself.