MegaMek / mekhq

MekHQ is a java helper program for the MegaMek game that allows users to load a list of entities from an XML file, perform repairs and customizations, and then save the new entities to another XML file that can be loaded into MegaMek.
http://megamek.org
131 stars 168 forks source link

Prisoner Ransom/Defection Nag clarification #4643

Closed repligator closed 1 month ago

repligator commented 1 month ago

Environment

Linux Java 17 Master (latest PR https://github.com/MegaMek/mekhq/commit/fbb0a02e62541aa66b146055a847e38bad50f86e)

Description

Let us assume that I have 10 prisoners, 5 of whom are willing to defect.

ransomDefectorsQ.format=You have %d prisoners willing to defect, ransom them for %s? %d uses the value for total number of prisoners. The nag currently reads "You have 10 prisoners willing to defect...", which isn't true.

Either the text should be changed to "You have 10 prisoners, some of whom are willing to defect,..." or %d should be changed to reflect the number of defectors "You have 5 prisoners willing to defect...".

IllianiCBT commented 1 month ago

Closing as resolved