MegaMek / mekhq

MekHQ is a java helper program for the MegaMek game that allows users to load a list of entities from an XML file, perform repairs and customizations, and then save the new entities to another XML file that can be loaded into MegaMek.
http://megamek.org
131 stars 169 forks source link

Fully repaired vehicles listed as "Crippled" in the hanger, when all they need is a crew. #4689

Open Nikarus2370 opened 1 month ago

Nikarus2370 commented 1 month ago

Not really a bug per-se. Just a minor inconsistency in the interface.

But this appears to have been present in most previous patches, but checking its there in 49.19

So situation. If "Tank" and "Naval" classed vehicles have 0 crew, their Status is listed as "Crippled" in the Hangar tab which is a tad confusing to look at especially if the machine looks fully repaired/isn't showing in the repair bay, etc.

If the unit has at least 1 crew member assigned it's status changes to "Undamaged"

Clicking through and checking most other unit types, other machines be they Mechs, ASF, CF, Dropships, Warships, VTOLs and many more if they lack crew but are in otherwise working order are listed "Undamaged".

Just for consistency sake, I feel it might be nice to change it so that the status of the Tank and Naval units be "Undamaged" if they aren't damaged and just lack crew. That or if possible, perhaps add a new status of "Needs Crew" which can be applied to the other unit types as well.

Thank you for your consideration, have a good day.

repligator commented 1 month ago

See also https://github.com/MegaMek/mekhq/issues/2323