search

MegaMek / mekhq

MekHQ is a java helper program for the MegaMek game that allows users to load a list of entities from an XML file, perform repairs and customizations, and then save the new entities to another XML file that can be loaded into MegaMek.
http://megamek.org
134 stars 171 forks source link

MHQ Startup Scripts broken #4772

Open repligator opened 2 months ago

repligator commented 2 months ago

Environment

MHQ 0.50.0 downloaded from here Linux Java 17

Description

MekHQ-0.50.0/MekHQ.sh , MekHQ-0.50.0/MegaMekLab.sh , MekHQ-0.50.0/MegaMek.sh are all 4 lines long. Needless to say, they do not function.

Algebro7 commented 1 month ago

MekHQ.sh works at least, it's just a wrapper that points to bin/MekHQ. The issues with them being non-functional are probably related to #4867. Can you try making it executable and running dos2unix on it to see if that fixes it for you?

rjhancock commented 1 month ago

Do they work in one of the nightlies or another action archive?

repligator commented 1 month ago

Sorry it took me so long to respond. I just checked tonight's nightly (https://github.com/MegaMek/mekhq/actions/runs/10968479230) and the startup script runs fine. It looks like this is the same issue as https://github.com/MegaMek/mekhq/issues/4867 . After running dos2unix it works just fine.

rjhancock commented 1 month ago

Alright. I have an idea of where the issue is just not sure how to solve it just yet.

The scripts themselves are just shells to the bin/ variants so that they use the latest ones from Launch4J so they aren't suppose to have anything else in them. Within the repo they do have the correct line endings and are marked executable.

This is an issue with how the release packages are built as Hammer does them manually (for now) on a Windows machine so the build scripts are doing something to them vs the GH Actions that are all running Linux.

Will see what can be done.