MegaMek / mekhq

MekHQ is a java helper program for the MegaMek game that allows users to load a list of entities from an XML file, perform repairs and customizations, and then save the new entities to another XML file that can be loaded into MegaMek.
http://megamek.org
133 stars 171 forks source link

Bug in Mission XP reward setting in Game Options #4790

Closed BTSS88 closed 1 month ago

BTSS88 commented 2 months ago

HQ's MegaMek. Windows 11 Java 17

Screenshot 2024-09-05 135202

In the Experience tab of the Game option, Mission success XP will always match Mission failure XP. If I put in two different numbers, the Success will always match Failure upon saving and exiting the option.

Name of player: Musket's Emergency Contractors

Musket's Emergency Contractors30530720.cpnx.gz

IllianiCBT commented 2 months ago

image

A good ol' fashioned copy-paste error. This should read:


    public int getMissionXpSuccess() {
        return missionXpSuccess;
    }
BTSS88 commented 2 months ago

Can you tell me which file this code is in so I can just change it myself? Thanks.

On Thu, Sep 5, 2024 at 2:01 PM Daniel L- @.***> wrote:

image.png (view on web) https://github.com/user-attachments/assets/669a2235-07a0-4b94-add3-735cafc12a3f

A good ol' fashioned copy-paste error. This should read:

public int getMissionXpSuccess() {
    return missionXpSuccess;
}

— Reply to this email directly, view it on GitHub https://github.com/MegaMek/mekhq/issues/4790#issuecomment-2330550074, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4TL2U4TVLZRN25BS6NKHOTZU7JTHAVCNFSM6AAAAABNVSZGASVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZQGU2TAMBXGQ . You are receiving this because you authored the thread.Message ID: @.***>

IllianiCBT commented 2 months ago

campaignOptions.java if you’re going to change it, mind putting in a PR with the corrected value?