MegaMek / mekhq

MekHQ is a java helper program for the MegaMek game that allows users to load a list of entities from an XML file, perform repairs and customizations, and then save the new entities to another XML file that can be loaded into MegaMek.
http://megamek.org
133 stars 171 forks source link

[0.50]: Infantry Bay Calculation for Transport Report is Incorrect, Multiplied by 5 #4801

Open UlyssesSockdrawer opened 2 months ago

UlyssesSockdrawer commented 2 months ago

Environment

Version: 0.50 release OS: Windows 11 10.0 (amd64) Java Vendor: Eclipse Adoptium Java Version: 17.0.12

Description

There appears to be a discrepancy between the Transport Capacity report accessible from the Command Centre with the number of infantry bays for transport capacity.

My campaign has a Union 2709 Combined Arms with 3 infantry platoon bays:

image

When viewing the Transport Capacity report, it shows that 15 bays are available, with 1 being filled by a platoon in my hangar.

image

The Reputation Report correctly shows that I have 3 bays available:

image

It seems that the transportation report may be multiplying the number of bays by 5.

Files

Save file & customs folder attached.

The Nova Dragoons30040115.cpnx.gz

customs.zip

SuperStucco commented 2 months ago

An older related one: https://github.com/MegaMek/mekhq/issues/2476

When you look at the Union Combined Arms model, the Summary tab shows Infantry Bay (2 doors) - 3.0 Foot platoons, while the TRO tab shows Bay 3: Infantry (Foot) (15) 2 Doors. The latter is likely showing tons of bay space, rather than a fixed multiple. Nearly all of the canon DropShips are built with foot infantry in mind (and basic rifle, at that), so having it list by platoon in ratings gets a little squirrelly when providing numbers. For example, it's reasonable to assume a motorized platoon would be stripped down to the equivalent of a foot (rifle) platoon for the sake of transport, with the extra gear stowed, when transported on one of these DropShips rather than one that has a dedicated motorized infantry bay.

UlyssesSockdrawer commented 2 months ago

To add to that, I have a jump infantry platoon in my hangar, but the bays are presumably for foot on the Combined Arms per the above comment, so something may be going on there too.

Thom293 commented 2 months ago

I believe this is related too. https://github.com/MegaMek/mekhq/issues/4949

At that time I posted that I didnt think it was MHQ related, but it may be able to be moved to MHQ.

For some reason MHQ is counting infantry bays and/or bay personnel as required, and when it transfers them to MM, it shows Dropships as invalid, since at least 49.19. Same for both custom and canon DS.

IllianiCBT commented 1 month ago

Can someone explain which report is incorrect, my brain is smooth so use small words :D

Saklad5 commented 1 month ago

Question, actually: are infantry bays supposed to count distinct platoons, or just individual troopers of the correct motive type? For instance, if you have three single-squad foot "platoons" of seven troopers each, do they occupy three foot infantry bays or 70% of one?

UlyssesSockdrawer commented 1 month ago

@IllianiCBT - I believe it is the Transport Capacity Report that is incorrect as it is showing the bay tonnage vs. the bay capacity in number of platoons.

You can test it by adding a Union Combined Arms - this design has three foot infantry platoon bays.

The reputation report shows 3 bays available to the unit. The Transport Capacity report shows the tonnage of the three bays - 5 tons per.