MegaMek / mekhq

MekHQ is a java helper program for the MegaMek game that allows users to load a list of entities from an XML file, perform repairs and customizations, and then save the new entities to another XML file that can be loaded into MegaMek.
http://megamek.org
133 stars 171 forks source link

Bug: BAR 0 Armor (Refit to 'Standard' in the 'Meklab) on Buffel causing 999 difficulty maintenance rolls and other errors #4832

Open OrbMonky opened 1 month ago

OrbMonky commented 1 month ago

Prerequisites and Pre-Issue Checklist

Severity *

Critical (Game-breaking/Crash): The game crashes or a core feature (like saving, loading, or network connection) is completely unusable.

Brief Description *

I refit a custom Buffel Engineering Vehicle (it's spelled with a non-english u with dots above it so it is harder to search for), I selected Standard as the armor option. It seems to think the vehicle has 'BAR 0 armor (X)' and this is causing it to roll 999 difficulty checks for maintenance. Other issues that seem related are that when attempting to refit a Buffel to this variant, it creates an error on launching the refit selection window and fails to load. Something is going wrong with this vehicle's customization which seems to be setting the wrong armor type, an issue that hasn't presented on other vehicles being set to 'standard' armor.

image image

Focus: Issue with what appears to be an incorrect armor type getting assigned during megamek's meklab refit process (these were refit from mekhq). This appears to affect maintenance and refit kits as well as repairs.

Steps to Reproduce

Create Buffel with 'Standard' armor option. Set a tech to maintain, advance to Maintenance Day. Secondary issue: Create Buffel with 'Standard' armor option, acquire second Buffel, attempt to refit second Buffel to the variant with 'standard' armor.

Operating System *

Windows 10

Java Version *

17

MekHQ Suite Version *

v0.50.0

Custom MekHQ Version

No response

Attach Files

Helena's Valkyries30250706.cpnx.gz customs.zip

Final Checklist

OrbMonky commented 1 month ago

After testing and reconfiguring the armor in Meklab proper, it seems like it was 'a grade' vs 'f grade' standard armor. To my knowledge, limited though it is, F grade (or whatever is the best grade if you're running the reversed order on quality names option) should be the only option that has standard armor. It was able to be set to standard armor for a grade that didn't have that as an option, seemingly. Saving it with a different armor type then changing to F grade and re-selecting standard armor fixed it after GM-restoring the corrected refit. image