MegaMek / mekhq

MekHQ is a java helper program for the MegaMek game that allows users to load a list of entities from an XML file, perform repairs and customizations, and then save the new entities to another XML file that can be loaded into MegaMek.
http://megamek.org
133 stars 171 forks source link

[0.50.01-SNAPSHOT] Loading existing campaign unassigns roles for personnel impacted by terminology change. #4833

Closed Tzahr closed 1 month ago

Tzahr commented 1 month ago

Prerequisites and Pre-Issue Checklist

Severity *

Medium (Gameplay Limitation): Non-core functionality is impaired, providing a suboptimal but playable experience.

Brief Description *

Importing a campaign created prior to the changes Mech -> Mek terminology change results in all personnel with roles that used the relevent term from being assigned as "None". So far, I have observed this affecting:

Others will likely similarly be impacted. Notably, this does not remove the Mek Warriors from the TOE. EDIT: correction, it also does not unassign Techs.

Steps to Reproduce

Import an existing campaign into the current run of Nightlies.

Operating System *

Windows 11

Java Version *

21.0.3

MekHQ Suite Version *

Free Text (type manually)

Custom MekHQ Version

0.50.01-SNAPSHOT - Revision: e0a790a6a4cfccb36f50625799b23898e0e8bd1a

Attach Files

No response

Final Checklist

Tzahr commented 1 month ago

As a knock-on effect, this also appears to cause affected personnel to lose their randomly generated portaits, even after their role is restored. I am not going to report this as a seperate issue, since resolving the role conversion will almost certainly also resolve this secondary effect.

IllianiCBT commented 1 month ago

Closing as resolved